New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple scrapers in an addon calls wrong library #22399
Comments
That's interesting. I'm not sure if it is by design or if it is a bug. Looking at the included scrapers they are typically separate: https://github.com/xbmc/xbmc/tree/master/addons That doesn't mean that it should be that way, it's just an observation. Someone else more familiar with the scraper add-ons may have to chime in. |
fhriley
added a commit
to fhriley/xbmc
that referenced
this issue
Jan 8, 2023
…nes multiple types Addons correctly handled having multiple types. However, CPluginDirectory did not know what addon type it was working with. When it retrieved the addon, it used the PLUGIN or UNKNOWN. This would only search on the first type of an addon, which meant an addon with multiple types would match incorrectly. This change makes CPluginDirectory aware of the type of addon it should retrieve so it always gets the correct addon type. Note that the changes any APIs are 100% backwards compatible. Fixes xbmc#22399
fhriley
added a commit
to fhriley/xbmc
that referenced
this issue
Jan 8, 2023
…nes multiple types Addons correctly handled having multiple types. However, CPluginDirectory did not know what addon type it was working with. When it retrieved the addon, it used the PLUGIN or UNKNOWN types. This would only search on the first type of an addon, which meant an addon with multiple types would match incorrectly. This change makes CPluginDirectory aware of the type of addon it should retrieve so it always gets the correct addon type. Note that the changes to any APIs are 100% backwards compatible. Fixes xbmc#22399
13 tasks
fhriley
added a commit
to fhriley/xbmc
that referenced
this issue
Jan 8, 2023
…nes multiple types Addons correctly handled having multiple types. However, CPluginDirectory did not know what addon type it was working with. When it retrieved the addon, it used the PLUGIN or UNKNOWN types. This would only search on the first type of an addon, which meant an addon with multiple types would match incorrectly. This change makes CPluginDirectory aware of the type of addon it should retrieve so it always gets the correct addon type. Note that the changes to any APIs are 100% backwards compatible. Fixes xbmc#22399 Signed-off-by: Frank Riley <fhriley@gmail.com>
fhriley
added a commit
to fhriley/xbmc
that referenced
this issue
Jan 8, 2023
…nes multiple types Addons correctly handled having multiple types. However, CPluginDirectory did not know what addon type it was working with. When it retrieved the addon, it used the PLUGIN or UNKNOWN types. This would only search on the first type of an addon, which meant an addon with multiple types would match incorrectly. This change makes CPluginDirectory aware of the type of addon it should retrieve so it always gets the correct addon type. Note that the changes to any APIs are 100% backwards compatible. Fixes xbmc#22399 Signed-off-by: Frank Riley <fhriley@gmail.com>
fhriley
added a commit
to fhriley/xbmc
that referenced
this issue
Jan 8, 2023
…nes multiple types Addons correctly handled having multiple types. However, CPluginDirectory did not know what addon type it was working with. When it retrieved the addon, it used the PLUGIN or UNKNOWN types. This would only search on the first type of an addon, which meant an addon with multiple types would match incorrectly. This change makes CPluginDirectory aware of the type of addon it should retrieve so it always gets the correct addon type. Note that the changes to any APIs are 100% backwards compatible. Fixes xbmc#22399 Signed-off-by: Frank Riley <fhriley@gmail.com>
fhriley
added a commit
to fhriley/xbmc
that referenced
this issue
Jan 22, 2023
…nes multiple types Addons correctly handled having multiple types. However, CPluginDirectory did not know what addon type it was working with. When it retrieved the addon, it used the PLUGIN or UNKNOWN types. This would only search on the first type of an addon, which meant an addon with multiple types would match incorrectly. This change makes CPluginDirectory aware of the type of addon it should retrieve so it always gets the correct addon type. Note that the changes to any APIs are 100% backwards compatible. Fixes xbmc#22399 Signed-off-by: Frank Riley <fhriley@gmail.com> Change to not reveal implementation details at the api surface. Use the type from the base class. Give the added hint field a better name Get the addon type to CPluginDirectory using the existing Directory api.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Describe the bug
Here is a clear and concise description of what the problem is:
I have the following
addon.xml
:This works fine in the kodi gui: I can add a movie content source and select my addon for it, and I can also add a tvshow content source and select my addon for it. However, when kodi actually runs the scraper, it always calls
movie_scraper.py
, even for tv shows. Is this expected behavior or a bug?Expected Behavior
Here is a clear and concise description of what was expected to happen:
Kodi calls
movie_scraper.py
for movies andtvshow_scraper.py
for tv shows.Actual Behavior
Kodi calls
movie_scraper.py
for movies andmovie_scraper.py
for tv shows.Possible Fix
To Reproduce
Steps to reproduce the behavior:
addon.xml
from above.Debuglog
The debuglog can be found here:
Screenshots
Here are some links or screenshots to help explain the problem:
Additional context or screenshots (if appropriate)
Here is some additional context or explanation that might help:
Your Environment
Used Operating system:
Android
iOS
tvOS
Linux
macOS
Windows
Windows UWP
Operating system version/name: MacOS 13.1
Kodi version: 19.5
note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.
The text was updated successfully, but these errors were encountered: