Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video Versions] ListItem.Overlay is always set to OverlayWatched.png for when versions set to show as folder. #24493

Closed
1 of 7 tasks
jurialmunkey opened this issue Jan 13, 2024 · 0 comments · Fixed by #24509

Comments

@jurialmunkey
Copy link

jurialmunkey commented Jan 13, 2024

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

The parent version of a movie with multiple versions will always have $INFO[ListItem.Overlay] set as OverlayWatched.png regardless of its actual watched status if the option to display multiple versions as a folder is enabled.

Selecting Marked as Unwatched from context does not change the watched status. Additionally, the watched status is set to watched regardless of whether the versions of the movie itself are watched.

You cannot see this bug in Estuary as the indicator always shows the versions indicator rather than watched status. That is another separate issue with Estuary in that priority of the indicator means that you can never see watched status.

Expected Behavior

Here is a clear and concise description of what was expected to happen:

The watched status should only be True (i.e. OverlayWatched.png) when all versions inside the folder are watched. Additionally selecting mark as watched/unwatched on the parent version folder should mark all items in the version as watched/unwatched (similar to how a set would function)

Actual Behavior

The watched status is always True so the version always shows as watched regardless of whether it has been or not.

Possible Fix

To Reproduce

Steps to reproduce the behavior:

  1. Settings > Media > Videos > Show videos with multiple versions as folder (enabled)
  2. Navigate to a movie with multiple versions and inspect the value of $INFO[ListItem.Overlay] to see that it is OverlayWatched.png
  3. Choose mark as unwatched and reinspect ListItem.Overlay to see that it hasn't changed.

Inspecting the overlay can be done by adding a simple label control to MyVideoNav.xml

<control type="label">
	<height>80</height>
	<bottom>40</bottom>
	<align>center</align>
	<textcolor>magenta</textcolor>
	<label>ListItem.Overlay = $INFO[ListItem.Overlay]</label>
</control>

Debuglog

The debuglog can be found here:

kodi.log

Screenshots

Here are some links or screenshots to help explain the problem:

Parent version always shows OverlayWatched.png in ListItem.Overlay regardless of choosing mark as watched/unwatched or if versions inside folder are actually watched or not.

You can see the output of my label control above in the magenta text in the screenshot:

screenshot00367

screenshot00370

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • macOS

  • Windows

  • Windows UWP

  • Operating system version/name: Windows 11

  • Kodi version: Omega nightlies.

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

@xbmc-gh-bot xbmc-gh-bot bot added the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label Jan 13, 2024
@KarellenX KarellenX added Feature: Video Versions/Extras and removed Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it labels Jan 13, 2024
@thexai thexai added Resolution: Fixed issue was resolved by a code change v21 Omega labels Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants