[video] Fix watched overlay image of parent movie item

[CrystalP]

Description

The watched/unwatched overlay icon doesn't need to be overriden to "always watched" for the parent item of versions when navigation of versions as a folder is enabled. It is already set with a reasonable value (watched status of the default version).

FYI @jurialmunkey could you confirm it fixes the issue.

I used the opportunity to refactor SetOverlayImage() calls a bit with a second commit, the API was confusing with an inverted bool condition, there was a weird +1 in the overlay index... No change in the logic or the results.

Motivation and context

Fix #24493

How has this been tested?

movie without versions watched/unwatched, movie with versions and default version watched/unwatched.

What is the effect on users?

Some skins depend on ListItem.Overlay

Screenshots (if appropriate):

The effect is not visible in standard Estuary but a change suggested in #24493 adds a label displaying the overlay image name in purple at the bottom of the screen.

before, with no versions watched:

after, with no versions watched, or versions watched except for the default version:

after, with the default version watched:

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• Student submission (PR was done for educational purposes and will be treated as such)
• None of the above (please explain below)

Checklist:

• My code follows the Code Guidelines of this project
• My change requires a change to the documentation, either Doxygen or wiki
• I have updated the documentation accordingly
• I have read the Contributing document
• I have added tests to cover my change
• All new and existing tests passed

[ksooo]

The fix seems to be correct.
And special thanks for this interface cleanup. It was so confusing before.

[jurialmunkey]

Thanks! Yes this is great. Working well / as expected now.

[Ch1llb0]

Just wondering as I'm adjusting my skin to the recent changes: Is the "reasonable value" for the watched status here really to take over the value of the default version? Shouldn't it behave like with sets: a median value of all versions?

[ksooo]

Shouldn't it behave like with sets: a median value of all versions?

Good question. Current design is different from everything else we have in Kodi. The node represents both a folder and a movie (the parent or default version). Currently, context menu actions, art, state indicators are for the movie, not the folder. We should not start mixing data!

[Ch1llb0]

Ok, makes sense with that explanation 👍🏻

[CrystalP]

This could be refined but I don't think in v21. There are some performance implications.