Prevent unnecessary colorspace conversions (regression in #4163)

[Shine-]

Previous PR disables all color spaces except YV12 for all renderers in Windows, not just for DXVA2/-HD. See forum for details: http://forum.xbmc.org/showthread.php?tid=183975&pid=1621870#pid1621870
This is the same patch minus the debug code.

[Voyager1]

patch looks fine to me. @wsoltys @a11599 - your thoughts?
jenkins build this please

[a11599]

Looks good to me as well.

[wsoltys]

@Voyager1 can't comment on that one as its not my area of knowledge. Pull it in if you guys and elupus are fine with it.

[Shine-]

Not sure whether this still has a chance of getting merged or #4201 is preferred now.
Either way, I cleaned it up as requested, removed the uninitialized processor from memory as suggested by afedchin and fixed mergeability with the current tree.

[elupus]

I noticed an issue. CWinRenderer::Configure can be called multiple times with different foramts without PreInit being called inbetween.

Thus SelectRenderMethod can not delete m_processor if we don't create it there.

[Shine-]

I guess that's the answer why "m_processor->Close();" instead of SAFE_DELETE in SelectRenderMethod(). Admitted, I didn't think that far, I just figured it's that way for a reason and kept it as is... ;-)

[Shine-]

Fixed indent (grml...), changed formatting and added brackets for readability.

[elupus]

I'm alright with this pull now. I've not tested it thou, so that needs to be done.

jenkins build this please

[t-nelson]

@Voyager1 @wsoltys @a11599 mind testing and reporting back?

[Voyager1]

just tested with hi10p material, on the following renderer settings dxva, pixelshaders, automatic. All works fine, the only thing is I cannot see in PS mode whether the color space is converted or not, my eyes aren't that precise :)
Is there anything to look for in a log or in the on screen stats (when pressing o) ?

[Shine-]

Not when pressing 'o', but if you check the debug log. There's a line that tells you which color space is being used as destination. If you play a Hi10P file w/ PS rendering without this second patch, it's going to say that the destination color space is "YV12". With this patch, it says "YV12P10". Can't tell you the exact wording since I'm still at work and can't check my saved logs. But I believe that it says "YV12" and "YV12P10", not "YUV420P" and "YUV420P10". Should be easy to find the line.

[Voyager1]

ok, thanks that was easy:
DXVA

19:58:48 T:6112   DEBUG: CDVDPlayerVideo::OutputPicture - change configuration. 1920x1038. framerate: 23.98. format: YV12

all others (Software, PS, Auto)

20:02:24 T:7364   DEBUG: CDVDPlayerVideo::OutputPicture - change configuration. 1920x1038. framerate: 23.98. format: YV12P10

And indeed I also tested without the patch and I'm only getting YV12.
From my perspective it's good to go.

[t-nelson]

@elupus Your button

[wsoltys]

Don't have much to test with but I'm fine with @Voyager1 tests.

[Voyager1]

Apologies button accident... Reopened

[Voyager1]

@elupus - if no further comments, please hit the merge button.