[settings] use timezone settings for all supported posix platforms except of android #4218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix something or did you just change it because it looks wrong? |
|
I changed it because it looks wrong in code comparing to frodo. I can test it on linux only. |
|
IIRC I messed up some of the #ifdef'ery concerning the timezone settings in my settings refactor. Haven't checked if someone has fixed it in the mean time or not. |
|
Ok. If this doesn't fix anything specifically, I'd like to hold off until |
|
Well, this should fix TZ settings on darwin and freebsd platforms. They shouldn't work there now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Frodo code for TZ settings they handled for all _LINUX platforms not including TARGET_ANDROID and AppleTV2 with iOS < 4.3 (see https://github.com/xbmc/xbmc/blob/Frodo/xbmc/settings/GUISettings.cpp#L1424)
Withal _LINUX defined for all posix platforms, and TARGET_POSIX defined for them too (see https://github.com/xbmc/xbmc/blob/Frodo/configure.in#L551)
The patch adds TZ handling for TARGET_POSIX && !TARGET_ANDROID. See #4095 and a2f3ca2 for more details.
I made it blind so help needed from platform devs.