Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Timers: Allow to change timer type for existing timers. #10057

Merged
merged 1 commit into from Jul 5, 2016

Conversation

@ksooo
Copy link
Member

commented Jul 1, 2016

This feature was requested several time sin the forum. With this PR it s possible in the timer settings dialog to edit the type of an existing timer or timer rule, for instance to convert a one time timer to a series recording.

@Jalle19 mind taking a look at the code.

@Tolriq

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2016

@ksooo how does that impact JSON ? Does it need API change to allow that ?
I've seen your comment on a previous PR, is the naming rewrite planned for v17 ?

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2016

@Tolriq no and no.

@Tolriq

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

@ksooo Anyway to have the just the JSON chance for v17 ?
There's already a lot of breaking chance in JSON API for v17.
Timer API was added in JSON in v17 alpha.
Currently no one use that API.

That would simplify a lot the future if v17 and v18 are not incompatible on a new feature.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2016

Good point, not sure whether I find the time for this, though. PR welcome.

@Tolriq

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

Tell me what to rename to what :) I have plans to include Timers in Yatse but for the moment I have no idea how it works as I do not use PVR in Kodi. So I do not even understand your naming changes :)

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2016

"repeating timer" -> "timer rule". That's it.

@Tolriq

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

Ok sounds pretty simple :)

Will try to find time before moving to do that.

@Tolriq

This comment has been minimized.

Copy link
Contributor

commented Jul 2, 2016

@ksooo I've checked quickly current definition. Can you explain me what the new description should looks like for the setters ?

Currently it's "the add/delete/edit should be done for all occurances" for repeating, but I'm not sure to understand the difference of this new timer rule definition, so need your description as I suppose it's a little different behavior.

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 2, 2016

Come up with a suggestion in a PR and I will be happy to review.

@ksooo ksooo force-pushed the ksooo:pvr-edit-existing-timers branch from ef2a83b to 9f8174f Jul 2, 2016

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2016

@Jalle19 Good to go?

@Tolriq thanks for the PR. Will have a look the next days.

@ksooo ksooo closed this Jul 4, 2016

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2016

Ooops.

@ksooo ksooo reopened this Jul 4, 2016

m_timerType = m_timerInfoTag->GetTimerType();
m_timerType = m_timerInfoTag->GetTimerType();

if (!m_timerType)

This comment has been minimized.

Copy link
@Jalle19

Jalle19 Jul 4, 2016

Member

Are there really any situations where a timer tag could be created and stored without a timer type?

This comment has been minimized.

Copy link
@ksooo

ksooo Jul 4, 2016

Author Member

In theory that's possible, yes. But you may be right, it's just theory and of no real value here. I will drop this.

This comment has been minimized.

Copy link
@Jalle19

Jalle19 Jul 4, 2016

Member

Thanks

@Jalle19

This comment has been minimized.

Copy link
Member

commented Jul 4, 2016

Apart from my previous comment, +1

@ksooo ksooo force-pushed the ksooo:pvr-edit-existing-timers branch from 9f8174f to d33dbfd Jul 5, 2016

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2016

jenkins build this please

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2016

travis-ci errors are unrelated.

@ksooo ksooo merged commit 9ffb616 into xbmc:master Jul 5, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details

@ksooo ksooo deleted the ksooo:pvr-edit-existing-timers branch Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.