Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[xbmc][fix] Fix theme xbt loading that broke during cleanup.in #9960 #10073
Found a race condition that seems to have been hidden and a screwup during cleanup clobbering state.
The race condition is that g_graphicsContext.GetMediaDir() isn't set to anything when first called, it's only later on during skin loading it's actually populated. If this happens now we fall back to the currently set skin.
@MilhouseVH I've tested with the Titan beta skin, I can't see any difference on the corners when using modern_rounded but works fine setting it to classic so I'm thinking it might be my eyes deceiving me or some change in the beta I tested. Would be great if you or the author can test the changes.
Yeah I saw it in the posted screenshots so that's why I'm doubting my own vision here. The classic theme option has rounded corners and switching between that and default it clearly changes the corners rounding so it could be something wrong with just the modern_rounded theme in the skin currently.
I'm pretty sure there's still an issue, though as you say it might be skin related (I've really no idea).
This is how Titan "modern_rounded" looked before PR9960 (ie. build #613):
The strange thing is that build #0704x, which is reportedly working correctly (ie. with rounded corners), looks the same as current kodi master to me (ie. second screenshot) so I'm not convinced that reverting PR9960 is actually working as reported - I'll ask the user to test #0704x again.
Then again, if you suspect this might be some race condition, it could be that it works some of the time...