[xbmc][fix] Fix theme xbt loading that broke during cleanup.in #9960 #10073
Conversation
|
Thanks, I'll include it in tonight's build (though a bit worried you can't see the difference rounded corners makes, it's fairly clear in the screenshots posted by the user). |
|
Yeah I saw it in the posted screenshots so that's why I'm doubting my own vision here. The classic theme option has rounded corners and switching between that and default it clearly changes the corners rounding so it could be something wrong with just the modern_rounded theme in the skin currently. |
|
I'm pretty sure there's still an issue, though as you say it might be skin related (I've really no idea). This is how Titan "modern_rounded" looked before PR9960 (ie. build #613): And now current kodi master (ie. with PR9960) and this PR: The strange thing is that build #0704x, which is reportedly working correctly (ie. with rounded corners), looks the same as current kodi master to me (ie. second screenshot) so I'm not convinced that reverting PR9960 is actually working as reported - I'll ask the user to test #0704x again. Then again, if you suspect this might be some race condition, it could be that it works some of the time... |
|
maybe we can get @marcelveldt to comment, if I understand it correctly he's the maintainer of the skin. |
|
oh nvm, had a look at it again and there was one more thing I failed to fix, have updated the PR and now it should be good to go for tonight @MilhouseVH. |
| : m_TimeStamp{0} | ||
| , m_themeBundle{false} | ||
| { | ||
| } | ||
|
|
||
| CTextureBundleXBT::CTextureBundleXBT(bool themeBundle) | ||
| : m_TimeStamp{0} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good now @Paxxi - many thanks! |
|
Great work, thanks for the quick fix. This issue was indeed reported on the forums |
Found a race condition that seems to have been hidden and a screwup during cleanup clobbering state.
|
jenkins build and merge this please |
Found a race condition that seems to have been hidden and a screwup during cleanup clobbering state.
The race condition is that g_graphicsContext.GetMediaDir() isn't set to anything when first called, it's only later on during skin loading it's actually populated. If this happens now we fall back to the currently set skin.
@MilhouseVH I've tested with the Titan beta skin, I can't see any difference on the corners when using modern_rounded but works fine setting it to classic so I'm thinking it might be my eyes deceiving me or some change in the beta I tested. Would be great if you or the author can test the changes.