Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Small improvements and fixes #10078

Merged
merged 5 commits into from
Jul 7, 2016
Merged

[cmake] Small improvements and fixes #10078

merged 5 commits into from
Jul 7, 2016

Commits on Jul 6, 2016

  1. [cmake] Print CMake version and add some warnings 

    CMake 3.5.1 suffers from a crash at configure time that happens on some
Systems: http://cmake.org/Bug/view.php?id=16044
This is fixed in 3.5.2.

Darwin requires CMake at least 3.4 or the usage of the patched version
in depends.
    @fetzerch
    fetzerch committed Jul 6, 2016
    Configuration menu
    Copy the full SHA
    3f855dc View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2016

  1. [cmake] Add CMakeHelpers (utilities for debugging CMake scripts)

    @fetzerch
    fetzerch committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    684bed6 View commit details
    Browse the repository at this point in the history

  2. [ColorManager] Replace non-standard VLA with vector 

    Variable-length arrays are not part of C++ and only allowed in C99. While
they are supported as a GCC extension (if -pedantic is not set), they
cannot be used with MSVC.

This commit replaces the VLA in ColorManager by a std::vector.
    @fetzerch
    fetzerch committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    2f94822 View commit details
    Browse the repository at this point in the history

  3. [cmake] Opt out if platform configuration cannot be found 

    For example on Darwin platforms this can indicate a missing toolchain
file.
    @fetzerch
    fetzerch committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    bd89024 View commit details
    Browse the repository at this point in the history

  4. [cmake] Fix export-files when building in-source 

    In-source builds were broken due to a mistake in the export-files
logic. Even though this commit resolves the problem, it is recommended
building out-of-source.
    @fetzerch
    fetzerch committed Jul 7, 2016
    Configuration menu
    Copy the full SHA
    bfb7355 View commit details
    Browse the repository at this point in the history