Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guilib: do not kill plugin script if we are waiting for user input #10080

Merged
merged 1 commit into from Jul 7, 2016

Conversation

FernetMenta
Copy link
Contributor

see title

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue Component: GUI engine labels Jul 7, 2016
@FernetMenta FernetMenta added this to the Krypton 17.0-alpha3 milestone Jul 7, 2016
@Tolriq
Copy link
Contributor

Tolriq commented Jul 7, 2016

@FernetMenta do you think this is possible to reset the timer when the dialog is shown ?

Reading code, if the dialog is shown for 29sec this only leave 1 sec to get the data.

Typical use case still Youtube browsing from a remote get to search screen, enter the text. 30 sec timeout should start at that moment and not take in account the X seconds he took to enter the data.

@FernetMenta
Copy link
Contributor Author

@Tolriq good input. I updated it, please review.

@Tolriq
Copy link
Contributor

Tolriq commented Jul 7, 2016

Well not at home to test and not fluent with Kodi threading / timers :)
I would have gone an easier way with your previous implementation, adding a simple boolean test in the while and updating the boolean in the loop if dialog was shown.
Would not have generated a pure 30 sec wait after a dialog but a 30sec + 30sec - dialog duration. But was simple.

Anyway if that code works and address the issue I'm fine with it :)

@FernetMenta
Copy link
Contributor Author

There was a case not considered by the old code that is now fixed: script terminates without calling DirectoryComplete.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants