IPlayer: properly sync playspeed with application #10103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
added
Type: Fix
|
@FernetMenta I've tested omxplayer and this PR. Seems to build fine and I couldn't spot an obvious regression. Mute still works, and audio is muted during trickplay. |
|
thanks for testing. seems it was some obsolete code. |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see title. There has been several workarounds in the past due to not properly synchronised playspeed. Having a variable in CApplicationPlayer assuming players do always have exactly the speed from the last command does not work.
Further player wants to change its speed according to events like failed seek i.e. when hitting the end of the stream on ff.
Removed CApplication::CheckPlayingProgress
I could not see this method doing anything useful. During testing this method caused the system hang in an endless while loop if speed == 0
@popcornmix I also removed bApplicationMuted from SetPlaySpeed. It turned out that omx_player was the only client of this. Such kind of specialisations should not be visible at the application layer. Please move appropriate action to player.