Add new option installed to Addons.GetAddons

[MartijnKaijser]

to allow listing of addons from loaded repositories. Add installed field to Addon.Fields / Addon.Details to indicate installation status.

Replaced #10007

[MartijnKaijser]

jenkins build and merge

[MartijnKaijser]

jenkins build and merge

[Tolriq]

Respect is really loss it seems ;) The close was a close, until merged code is mine.

Assume your act and ask before acting like you always do.

I officially ask that you write your own code for that, as you have not my authorization to copy it and use it.

You do not respect users, opposite is true.

[FernetMenta]

if the author of this code does not want it to be merged, it has to be respected.

[MartijnKaijser]

then the author has no business anymore on xbmc repo

[Tolriq]

No problem, I did try again to help, and it was cool and working until you can't refrain from your usual stuff :)

I loose nothing, Kodi users do, but no one cares about users here right ? :)

Have a nice day, I'll enjoy my holidays and will stop thinking about Kodi future, let's hope @FernetMenta have enough strength to keep to boat floating.

And BTW this code can be merged in v18 without any problems by anyone but @MartijnKaijser I certainly does not want to be associated on the same PR.

[stefansaraev]

I guess the reason for this drama is another PR locked. (the discussion was fine, and I was about to write there about upcoming ipv6 adoption and security sh** I expect to happen, but the PR was locked right before I pushed "comment" button). what about you guys calm down and re-think ;)

[MartijnKaijser]

Discussion was not fine cause it was the same all over again about general lack of security in Kodi which every one already knows and should know. That was not what the PR is about. You could start the discussion in every PR that handles JSON or whatever. Fix the root cause and start by encrypting the password files.
He has a history of spamming whatever he wants in whatever PR he thinks he sees fit. It's always the same with him.

[stefansaraev]

discussion was perfectly fine and in line with the PR in my opinion. you can't ignore the problem forever (and I say it again, that I am not a security fanatic). I wont comment on his past history but he has valid points.

it's fine to merge a PR no matter his opinion. a PR should not be locked for discusison just because you may not like his past "spamming" history. he did not offend anyone and the tone was ok.

my 2 cents and sorry for the spam.

[Tolriq]

Just lol :) So participating in a discussion is spamming ? You hate me, everyone knows that, and act not by thinking but just by hate.

A nice quote :

I don't give a damn what you think. Your attitude over the years makes my hate towards you grow day by day. Fact is I'm not alone in this.

Anyone else saying the exact same thing as me would not have given a lock, you hate merging my contributions, you have 0 respect for anything, cf the try to bypass my decision about this PR in less than a minute.

You insult peoples every where possible, you say wrong things a lot in the forums and can't stand to be corrected, no problem, but locking discussion each time you are wrong without arguments is just giving a poor vision of you, maybe worse than your forum actions ;)

The PR is about forcing users to open Web Server for a feature without securing the web server or warning the users .... The discussion is of course the correct place you want the feature, you have no argument since there's none, so you lock discussion :) Usual Martijn stuff.

You can on one hand say :

Discussion was not fine cause it was the same all over again about general lack of security in Kodi which every one already knows and should know.

And at the same time

I want to get this PR in ASAP before window closes

They are opposite decisions, this is a total non sense.

[NedScott]

I agree that Martijn needs to relax about Tolriq, and that it's disrespectful to go about a PR this way, and so on, but I have to say something:

I officially ask that you write your own code for that, as you have not my authorization to copy it and use it.

You can't do that. Once other people have seen your code on github you can't do a "takeback" on the GPL. A change was made to a GPL document, it was published/released in the form of github, it's a done deal. That's why some companies don't push to github/etc right away (however people may feel about that). Once they do, compiled or not, it's up for grabs.

I know that misses the actual point of the matter here, which is its own issue that needs to be dealt with, but I it's important that no one looks back at this and thinks there is precedent for "takebacks" on PR'ed GPL documents.

Sorry for the interruption. Everyone may precede with the already in-progress disputes about respect, security, outside comments, and all of that.

[koying]

I officially ask that you write your own code for that, as you have not my authorization to copy it and use it.

and

if the author of this code does not want it to be merged, it has to be respected.

WTF. Some people needs to be reminded what GPL is.
It's "give and take", not "give and respectfully, with deference, request permission to be given".

If you modify gpl code and publish your changes, you implicitely agree that your changes can be picked without further approval, period.
Github's PR mechanism is a nice way to have code changes pushed to upstream, but let's not forget it's only a convenience. GPL predates PR's by a long shot...

[Tolriq]

Yeah I get the message :)

Fuck users, fuck devs, do not respect anything and complains about others that do not respect either.

BTW after Martijn stupid act I did delete the branch. It's try to give. Delete before taken. Quite a big difference but I know that no one cares about the difference.

And whatever GPL may or may not say. Someone asking something should not be answered fuck you we do not care ;) Specially after the irrespectful actions before.

Martijn acts are correct. I'm wrong even if 100% of previous cases I was right about him ;)

Anyway the north and Internet remembers.

[koying]

BTW after Martijn stupid act I did delete the branch. It's try to give. Delete before taken. Quite a big difference but I know that no one cares about the difference.

No, there is zero difference. That you deleted the branch is a technicality.
You published your code, so it was pickable. Period.

Unbelievable that such basics of open-source has to be reminded...

[Tolriq]

Unbelievable that basic human relationship and respect have to be reminded ....

What a stange world IMO :)

Anyway I see it's merged with a big fuck you to me. No problem if all think this is how things should be done I certainly stop trying to talk as this is not the world I want to participate.

But I'm sure others will think this is not correct ;)

[koying]

Respect is due to the hundredth of devs who created Kodi over more than 10 years.
You are incredibly unrespectful to them for trying to escape your GPL obligations in trying to prevent them to benefit from your change.

If you don't agree to the GPL, keep your code to yourself, as easy as that.
Once you publish it, you give the whole world an irrevocable license to use it as they see fit, for free. You just don't have the right to deny "authorization to copy it and use it" anymore.

[Tolriq]

Do I compile or distribute Kodi ? No...

Is there any package made by me with this code ? No...

Do I own copyright of that code ? Yes.

You are seeing GPL where it does not belong.

Anyway daring to day I'm not respectful after this situation is a pure joke :)

Thanks for making me smile today as I'm tired after the flight it was good.

So much try to justify a complete lack of respect by trying to say I'm not respectful ....

[koying]

Do I compile or distribute Kodi ? No...
Is there any package made by me with this code ? No...
Do I own copyright of that code ? Yes.
You are seeing GPL where it does not belong.

Did I say you had to publish your code? No.
I assumed you distributed no binary. (On a side note, I expected that you compiled it for testing, though).

But you did, so are your published modifications of GPL code automatically licensed under GPL? Absolutely!
Your whole branch is GPL, including your modifications. (https://www.gnu.org/licenses/old-licenses/gpl-2.0-faq.en.html#GPLModuleLicense)

[NedScott]

Two different issues here.

One is just a minor technicality about the GPL. Out of respect for you, I would rather see this not get merged until the second issue is addressed. It is not required by law, but I would hope that Team Kodi would still wait for everyone's sake. I was only interested in clarifying the GPL part.

The second issue is Martijn and his apparent dislike for you. Martijn is clearly in the wrong, and I hope the other people on Team Kodi bring this up with him. He wants your code, but not your comments, and he seems to hate you. Heaven knows why, and he was out of line for closing that other discussion. The conflict is very strange and very frustrating.

I'm sorry I said anything before. Even if the GPL allows this, I gave you the wrong impression with my comment. I sometimes focus/comment on the wrong thing, without really thinking about the big picture. Now I feel bad that you and Koying are arguing at each other over this. Being technically right or wrong about the GPL means nothing if the contributors are disrespected, because then they won't want to do any further contribution.

I hope there is a way forward here. Maybe after some time to allow things to cool off?

[Tolriq]

As I said on another thread even if it is covered by GPL (still unsure but let's assume) that's not the point of the total disrespect.

You are are the bus stop you smoke peoples ask you to stop. You can stop, or move away, or say fuck you, or say fuck you and expire the smoke to the head of the asker. Or the hardcord one expire the smoke then light 2 or 3 just for fun.

This is the last choice that Kodi team in it's entire have chosen by force merging that code despite my ask..

You can justify as long as you want that you can do that. The question is should you ? And the answer in a normal world is far from the one you chose.

[Tolriq]

Missed ned message as on phone.

PR is merged already :) I was told Team discussed internaly and decided they do not care about my ask and want this merged now

[koying]

You are are the bus stop you smoke peoples ask you to stop

Bad metaphor. Merging your code did not harm you.
Replace "smoking" by "shirt color" and think again. Should we move away because you don't like our shirt color, all of a sudden, while you offered the shirt in the first place?

[Tolriq]

Of course it harms point of view again and perfect metaphore.

Read ned comment. You can't at the same time hate me and refuse contribution and at the same time take things when you want :)

Anyway talking to a wall I'm a bad guy of course Kodi is the good with that move it's obvious :)

[Tolriq]

#10140

I missed the last comment after my remark there.

We have reached the maximum level of fuck you. Very nice touch from the Team.

Did not thought the Team would not only cross (by a large factor) the line but be proud of it ......

I guess you will find an excuse for that comment instead of a sorry ? ... This is GPL and respect ?

Anyway thanks @NedScott and @FernetMenta for support and being normal persons :)

When I think I'm here and contributing one alway or another to Kodi since 2009 way before some came :)

[stefansaraev]

beware, you are a real human, who has a name and address.

take your shit out of github, please.

EDIT: @p1ngb4ck you deleted your comments, still 500+ people have them in their mailboxes. deleting your comments was not what I meant by "take your shid out of github" btw.

[p1ngb4ck]

And for the Rest of Team Kodi: IT IS DEFINITELY NOT TOLRIQ WHO HAS FORGOTTEN ABOUT THE BASICS OF OPEN SOURCE. They way you acted is briefly spoken : ZUM KOTZEN (in german .. you can look it up .. means I got to puke if I think about that nonsense you are talking to defend this massive security flaw)

[stefansaraev]

he is not. it is just that your behaviour is not acceptable here, your behaviour risks this conversation locked down, and even you banned from this project.

[p1ngb4ck]

Yeah you are perfectly right. I AM misbehaving. What other options do I have to make clear HOW bad this idiotism is ? They are putting users at risk. I just finished a POC for it...
Just to make my point clear enough : Mr Martijn Kaijser has PROVEN by action, that he is ABSOLUTELY not able to fulfill the job he should do. He is NOT aware of the most basic security concepts, thoughts and (most important !!) -morals&ethics.
This guy absolutely MUST NOT be in charge here any longer. He himself is a major security risk for every Kodi user.

[stefansaraev]

if you start attacking a project with millions of users, a project I (and many more) invested years in, and make it so it has 0 active regular users, you'll soon start to have very serious real life problems.

calm down your voice, dont behave like a stupid kid. github is place for development, it is not a place for such discussions, and obviously not a place to tell people "die die die"

[p1ngb4ck]

youre right this is why i deleted that. I kept some of my comment though, because I am really really angry. And IF you are a developer too, you dont need to like my methods, I can understand that well .. but you should understand why I go fuckin` nuts right now, after reading about the fact, that one of the devteam members is soooooooo horribly stupid to promote and merge insecure webservices ... this is really really nuts. And I hope & know I will not be the only one that thinks like that... The only ones that do know "better" is the kodi dev team member mr. kaijser

[stefansaraev]

thank you for spamming 500+ people.

[p1ngb4ck]

Was a pleasure. Wait till 2000 people use my POC for the security flaw they designed on purpose :D

[stefansaraev]

and you have no right to go nuts about decisions, made in an opensource project.

some of us dont give a fuck how eleet your github username sounds, instead of insulting others and writing "poc"s, make this project better, fix the issues yourself and contribute

Was a pleasure. Wait till 2000 people use my POC for the security flaw they designed on purpose :D

real-life issues, beware..

EDIT: no. I am not a (real, true) developer. does that make you happy

[koying]

And IF you are a developer too

p1ngb4ck: 1 contribution in the last year
stefansaraev: 1,307 contributions in the last year

You have to love the "too" :D

[fritsch]

Always nice to see peoply getting angry starting to punish innocent users and making them pay for own feelings ...

Geh nach Hause. Ob du recht hast oder nicht ist egal, dein Verhalten widerruft die Berechtigung hier mit zu reden. Egal was das andere Sandkastenkind vorher gemacht hat.