Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set tvshow thumb on *all seasons node #10141

Merged
merged 1 commit into from Jul 28, 2016

Conversation

@BigNoid
Copy link
Member

commented Jul 19, 2016

Can't find when this was lost, but this was default behaviour in previous versions. Without this PR it shows the default folder image.

Not sure how to fix and maybe unrelated but there's an issue when selecting manage in the context menu on this node.
It doesn't open the manage section where there should be an entry Choose art.

@BigNoid BigNoid force-pushed the BigNoid:all_seasons_thumb branch from 6fac08c to b6cafc0 Jul 20, 2016

@axbmcuser

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2016

I've been missing that. Works here. Thanks.

@BigNoid

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2016

jenkins build this please

@BigNoid BigNoid merged commit e14616e into xbmc:master Jul 28, 2016

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins.kodi.tv You did a great job. Have a cookie.
Details

@BigNoid BigNoid deleted the BigNoid:all_seasons_thumb branch Jul 28, 2016

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2016

With this PR, I'm not seeing any "season all" posters, or tvshow fanart at all.

I now see this in Estuary:

Imgur

Notice the fanart is also missing.

Without this PR (ie. only this PR reverted) I see the following:

Imgur

ie. both season-all poster and tvshow fanart are present.

My season-all poster and fanart are already cached in the texture cache:

017717|8/87ff64f0.jpg|0000|0000|0002|2015-07-10 03:40:42|2015-07-10 04:40:29|nfs://192.168.0.3/mnt/share/media/Video/TVShows/Marvel's Daredevil/season-all-poster.jpg
017440|f/fbb112cd.jpg|1080|1920|0032|2016-07-19 16:33:46|2016-07-29 01:17:15|nfs://192.168.0.3/mnt/share/media/Video/TVShows/Marvel's Daredevil/fanart.jpg

These are the items in my tvshow folder:

Imgur

I'm seeing identical behaviour on LibreELEC and Ubuntu. Reverting just this PR restores season-all-poster.jpg poster and tvshow fanart visibility. I'm not seeing any errors logged to the debug log.

To be honest, I'm not entirely sure what problem this PR is trying to solve, as (for me) season-all posters were being displayed correctly without any issues, but now they (and fanart) are not being displayed.

@BigNoid

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2016

I see that ListItem.Art(fanart) is indeed now missing. Will revert.

@axbmcuser

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2016

The problem which remains is the following - as far as i can see:

The "All seasons" entry can't access the path to the seasons-all poster from within "itemlayout" or "focusedlayout" in the list itself. The working estuary listview @MilhouseVH posted has the poster outside of the list, which is the reason why it works there.

Once you switch to a view type which uses the poster inside "itemlayout" or "focusedlayout" (using a "panel" control for example), the season-all poster is not shown.

@BigNoid

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2016

This problem needs a proper fix, hence why I reverted it. It has to do with the parent folder item, once that is disabled all is working as it should.

@axbmcuser

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2016

I did not mean to disagree with reverting. It was just the answer to @MilhouseVH asking
"I'm not entirely sure what problem this PR is trying to solve" :)

@MilhouseVH

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2016

@axbmcuser: as BigNoid says, you also experience different behaviour (without this PR) when enabling "Show Parent folder items":

Parent folder ENABLED:

Imgur

Parent folder DISABLED:

Imgur

Since I normally have the Parent folder disabled I didn't see a problem that needed solving! But thanks for explaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.