Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
set tvshow thumb on *all seasons node #10141
Can't find when this was lost, but this was default behaviour in previous versions. Without this PR it shows the default folder image.
Not sure how to fix and maybe unrelated but there's an issue when selecting
Jul 28, 2016
With this PR, I'm not seeing any "season all" posters, or tvshow fanart at all.
I now see this in Estuary:
Notice the fanart is also missing.
Without this PR (ie. only this PR reverted) I see the following:
ie. both season-all poster and tvshow fanart are present.
My season-all poster and fanart are already cached in the texture cache:
These are the items in my tvshow folder:
I'm seeing identical behaviour on LibreELEC and Ubuntu. Reverting just this PR restores
To be honest, I'm not entirely sure what problem this PR is trying to solve, as (for me)
The problem which remains is the following - as far as i can see:
The "All seasons" entry can't access the path to the seasons-all poster from within "itemlayout" or "focusedlayout" in the list itself. The working estuary listview @MilhouseVH posted has the poster outside of the list, which is the reason why it works there.
Once you switch to a view type which uses the poster inside "itemlayout" or "focusedlayout" (using a "panel" control for example), the season-all poster is not shown.
@axbmcuser: as BigNoid says, you also experience different behaviour (without this PR) when enabling "Show Parent folder items":
Parent folder ENABLED:
Parent folder DISABLED:
Since I normally have the Parent folder disabled I didn't see a problem that needed solving! But thanks for explaining.