Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depends][xbmc][fix] Get rid of wdk requirement #10143

Merged
merged 1 commit into from
Jul 20, 2016
Merged

Conversation

Paxxi
Copy link
Member

@Paxxi Paxxi commented Jul 19, 2016

Bump sdk to Win 10 as cmake defaults to that for addons anyway. Add the few headers we need from wdk as a package to simplify setup

…he few headers we need from wdk as a package to simplify setup
@Paxxi Paxxi added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality Platform: Windows Component: Depends labels Jul 19, 2016
@afedchin
Copy link
Member

is there any benefits from sdk10? and why cmake uses it as default?

@Paxxi
Copy link
Member Author

Paxxi commented Jul 20, 2016

Not for us, no. I assume cmake just picks the newest, or runs vcvars.bat which defaults to newest. There's also no downside to using it. I was a bit confused when doing the 2015 upgrade and thought it's best to target the lowest possible. In hindsight this has only caused trouble with having to install an extra sdk.
This PR's not very technical but rather to make the dev setup on windows easier and less error-prone.

@afedchin
Copy link
Member

thanks for clarifications

@Paxxi
Copy link
Member Author

Paxxi commented Jul 20, 2016

jenkins build this please

@Paxxi Paxxi merged commit d3258c0 into xbmc:master Jul 20, 2016
@Paxxi Paxxi deleted the wdk branch July 20, 2016 09:56
@Paxxi Paxxi added this to the Krypton 17.0-alpha3 milestone Jul 20, 2016
@garbear
Copy link
Member

garbear commented Aug 5, 2016

I still need WDK 8.1 installed to compile Kodi on Windows 7. The headers in mini_wdk-win32.7z seem to use structs and typedefs that aren't available on windows 7

@Paxxi
Copy link
Member Author

Paxxi commented Aug 5, 2016

If you have sdk 10.x installed it should be fine

@garbear
Copy link
Member

garbear commented Aug 5, 2016

Can you make a note of this on the wiki?

On Aug 4, 2016 10:30 PM, "Pär Björklund" notifications@github.com wrote:

If you have sdk 10.x installed it should be fine


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10143 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAgcGi1xOoG8igI2ZL87Cgo4RszAFHJEks5qcsp7gaJpZM4JQB_L
.

@Paxxi
Copy link
Member Author

Paxxi commented Aug 5, 2016

I updated the wiki when this went in I think or maybe it was for another change but it does say to install sdk 10

@garbear
Copy link
Member

garbear commented Aug 5, 2016

lol you mean the big image that takes up the entire screen? my powers of observation are incredible :)

@Paxxi
Copy link
Member Author

Paxxi commented Aug 5, 2016

haha yeah that one :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Platform: Windows Type: Cleanup non-breaking change which removes non-working or unmaintained functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants