-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[depends][xbmc][fix] Get rid of wdk requirement #10143
Conversation
…he few headers we need from wdk as a package to simplify setup
is there any benefits from sdk10? and why cmake uses it as default? |
Not for us, no. I assume cmake just picks the newest, or runs vcvars.bat which defaults to newest. There's also no downside to using it. I was a bit confused when doing the 2015 upgrade and thought it's best to target the lowest possible. In hindsight this has only caused trouble with having to install an extra sdk. |
thanks for clarifications |
jenkins build this please |
I still need WDK 8.1 installed to compile Kodi on Windows 7. The headers in mini_wdk-win32.7z seem to use structs and typedefs that aren't available on windows 7 |
If you have sdk 10.x installed it should be fine |
Can you make a note of this on the wiki? On Aug 4, 2016 10:30 PM, "Pär Björklund" notifications@github.com wrote:
|
I updated the wiki when this went in I think or maybe it was for another change but it does say to install sdk 10 |
lol you mean the big image that takes up the entire screen? my powers of observation are incredible :) |
haha yeah that one :) |
Bump sdk to Win 10 as cmake defaults to that for addons anyway. Add the few headers we need from wdk as a package to simplify setup