[osx] fix media key control for next and previous track #10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Memphiz ping |
|
mhhh i wonder why those had wrong keycodes then before @davilla do you have a clue about that? (unlikely i know...) - well lets hope that its not something that only works with newer osx versions then ... jenkins build this please |
|
not a clue, too far back in time. |
| @@ -442,8 +442,8 @@ - (void) deviceDidUnMountNotification:(NSNotification *) note | |||
| #define VK_MEDIA_PREV_TRACK 0xB1 | |||
| #define VK_MEDIA_STOP 0xB2 | |||
| #define VK_MEDIA_PLAY_PAUSE 0xB3 | |||
| #define VK_REWIND 0x9D | |||
| #define VK_FAST_FWD 0x9E | |||
| #define VK_REWIND 0xB1 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@Memphiz swapped the codes |
|
I'm ok with this. Please have a look in the osx forum in case there are issues with this reported by users - if you can . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use the media controls for previous and next track on mac.
Without this PR they would invoke f14 and f15 which have no action set in the keymaps.