EGLNativeTypeAmlogic: Enable GUI scaling when framebuffer size is less than output res #10332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less than output resolution For 4K output Kodi renders GUI at 1080p and this results in GUI covering only 1/4 screen. This patch enables hardware upscaling if output resolution is greater than rendered GUI resolution.
| @@ -53,6 +53,8 @@ class CEGLNativeTypeAmlogic : public CEGLNativeType | |||
| protected: | |||
| bool SetDisplayResolution(const char *resolution); | |||
| void SetupVideoScaling(const char *mode); | |||
| void DealWithScale(const RESOLUTION_INFO &res); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@codesnake that looks not clean in my opinion, please review as it is "your" platform :-) |
kszaq
added a commit
to kszaq/LibreELEC.tv
that referenced
this pull request
Aug 26, 2016
Issues with previous set of patches: - at some 4K output resolutions GUI was rendered at 1080p and covered only 1/4 of screen due to not changed iWidth and iHeight parameters - rendering GUI at 4K while playing high-bitrate 4K video caused stuttering Changes introduced in this patch: - rewrite platform_init to be aware of 4K resolutions passed by uboot in "hdmimode" parameter - always set virtual framebuffer resolution to 1920x2160 (like Kodi does) - remove Kodi patch to render GUI at 4K - add Kodi patch (xbmc/xbmc#10332) to upscale GUI when screen resolution is 4K
kszaq
added a commit
to kszaq/LibreELEC.tv
that referenced
this pull request
Aug 27, 2016
Issues with previous set of patches: - at some 4K output resolutions GUI was rendered at 1080p and covered only 1/4 of screen due to not changed iWidth and iHeight parameters - rendering GUI at 4K while playing high-bitrate 4K video caused stuttering Changes introduced in this patch: - rewrite platform_init to be aware of 4K resolutions passed by uboot in "hdmimode" parameter - always set virtual framebuffer resolution to 1920x2160 (like Kodi does) - remove Kodi patch to render GUI at 4K - add Kodi patch (xbmc/xbmc#10332) to upscale GUI when screen resolution is 4K
|
@kszaq please do not refer this PR in a commit message cause that will spam the PR |
|
@kszaq Can you confirm this PR handles correctly all video view modes (I mean Normal, Zoom, Wide Zoom etc)? |
codesnake
pushed a commit
to codesnake/LibreELEC.tv
that referenced
this pull request
Jan 31, 2017
Issues with previous set of patches: - at some 4K output resolutions GUI was rendered at 1080p and covered only 1/4 of screen due to not changed iWidth and iHeight parameters - rendering GUI at 4K while playing high-bitrate 4K video caused stuttering Changes introduced in this patch: - rewrite platform_init to be aware of 4K resolutions passed by uboot in "hdmimode" parameter - always set virtual framebuffer resolution to 1920x2160 (like Kodi does) - remove Kodi patch to render GUI at 4K - add Kodi patch (xbmc/xbmc#10332) to upscale GUI when screen resolution is 4K
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 4K output Kodi renders GUI at 1080p and this results in GUI covering only 1/4 screen.
Example: https://forum.libreelec.tv/thread-1355-post-9983.html#pid9983
This patch enables hardware upscaling if output resolution is greater than rendered GUI resolution.
Another solution would be to render GUI at full resolution but there are 2 disadvantages: