Make "Next" visible for chapters in Estuary's OSD #10353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's a design decision to hide the next button when it has no use (eg clicking on it and nothing happens). So instead of removing that, I would add the following: |
Thanks to Guilouz and the users on the forum for catching this. "Previous" on the OSD for Estuary is always visible (I assume because it can be used to "restart" a video), but "Next" has a condition to only show when there is a playlist with more than one item. I think this is a simple error, and it was forgotten that next/prev buttons are also used for chapter skipping, rather than an intentional design decision.
|
Like this? |
NedScott
changed the title
|
Yep, looks good. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Guilouz and the users on the forum for catching this.
"Previous" on the OSD for Estuary is always visible (I assume because it can be used to "restart" a video), but "Next" has a condition to only show when there is a playlist with more than one item. I think this is a simple error, and it was forgotten that next/prev buttons are also used for chapter skipping, rather than an intentional design decision.
EDIT: updated to only show up for when there are chapters or playlists