[PVR] Recordings: Prevent thumbnail extraction (as it cannot work pro…

[ksooo]

…perly without major pvr addon api changes).

Fixes the ugly problem reported here: #10333 (comment)

@Jalle19, @FernetMenta good to go? I think I now found a good place for the "pvr recording check"...

[ksooo]

@axbmcuser fyi

[ksooo]

jenkins build this please

[FernetMenta]

Could you wait until Saturday? Why got this broken again? iirc I have fixed this some time ago.

[ksooo]

iirc I have fixed this some time ago.

@FernetMenta You mean this fix, right? https://github.com/xbmc/xbmc/blob/master/xbmc/cores/VideoPlayer/DVDFileInfo.cpp#L107

Fine, but there are more cases you didn't catch. So, it's still broken, not again, imo. ;-)

There are many places where CVideoThumbLoader instances are created.

CVideoThumbLoader instanciates and starts CThumbExtractors => https://github.com/xbmc/xbmc/blob/master/xbmc/video/VideoThumbLoader.cpp#L417

CThumbExtractor::DoWork not only calls CDVDFileInfo::ExtractThumb (the case you fixed), but also CDVDFileInfo::GetFileStreamDetails => https://github.com/xbmc/xbmc/blob/master/xbmc/video/VideoThumbLoader.cpp#L140

My approach is more restrictive than yours because it generally prevents CThumbExtractor to access pvr recordings, regardless from where it's called. BTW, I did not invent this "type filter" approach at the beginning of CThumbExtractor::DoWork, I just added one case.

EDIT: In case we agree to merge this PR, your abovementioned fix could even be removed, as CDVDFileInfo::ExtractThumb gets exclusively called by CThumbExtractor::DoWork, which now will never call this any more on pvr recordings. So, we would have a perfect filter at a single place.

[FernetMenta]

Thanks for explanation. Go ahead

In case we agree to merge this PR, your abovementioned fix could even be removed

could you do this? maybe move the other exceptions like IsDiscImage to the other place too?

[ksooo]

@FernetMenta yep, will do.

[ksooo]

In case we agree to merge this PR, your abovementioned fix could even be removed

could you do this? maybe move the other exceptions like IsDiscImage to the other place too?

@FernetMenta done. IsDiscImage check was at "the other place" already, btw.

[ksooo]

jenkins build this please

[ksooo]

Travis error is unrelated