Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[guilib] drop support for using hyphen as none value #10389

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

tamland
Copy link
Member

@tamland tamland commented Sep 3, 2016

There's currently many code paths that doesn't handle the "-" magic value. It's not clear to me why this value was used instead of empty values in the first place; which is commonly always handled...

We should probably schedule this v18 as it breaks all skins relying on "-" being interpreted as an empty value.

@MartijnKaijser
Copy link
Member

@ronie perhaps you can already include this in skin changes thread? If no skin uses it anymore we can perhaps add it.

@Hitcher
Copy link
Contributor

Hitcher commented Sep 19, 2016

What should we use instead? If I use -
<texture></texture>
Notepad++ will change to this when I use Pretty print -
<texture/>

@ronie
Copy link
Member

ronie commented Sep 19, 2016

both are fine

jingai added a commit to jingai/skin.metropolis that referenced this pull request Sep 23, 2016
@rjsachse
Copy link
Contributor

Would this work with the progress control as well? At the moment I have to create a blank texture for the background. eg for the cache progress.

@ronie
Copy link
Member

ronie commented Feb 23, 2017

good to go?

@tamland
Copy link
Member Author

tamland commented Feb 24, 2017

if jenkins still approves, so jenkins build this please

@ronie
Copy link
Member

ronie commented Feb 24, 2017

windows failure is unrelated

@ronie ronie merged commit e1c28e2 into xbmc:master Feb 24, 2017
@Rechi Rechi added this to the L 18.0-alpha1 milestone Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants