Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] bugfixes #10442

Merged
merged 11 commits into from Sep 11, 2016
Merged

[Estuary] bugfixes #10442

merged 11 commits into from Sep 11, 2016

Conversation

ronie
Copy link
Member

@ronie ronie commented Sep 9, 2016

10 fixes for issues reported here:
http://forum.kodi.tv/showthread.php?tid=262373

and there (team only):
https://github.com/xbmc/skin.estuary/issues

will squash after review

@ronie ronie added Type: Fix non-breaking change which fixes an issue Component: Skin labels Sep 9, 2016
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta2 milestone Sep 11, 2016
@BigNoid
Copy link
Member

BigNoid commented Sep 11, 2016

Looks good to me. We can probably get rid of the old rating flags completely with BigNoid@2d7c3e1

@ronie
Copy link
Member Author

ronie commented Sep 11, 2016

@BigNoid but subtitles use a 0-5 rating scale...i don't think that would work
additionally, the new images are twice as wide as the old ones.

@BigNoid
Copy link
Member

BigNoid commented Sep 11, 2016

but subtitles use a 0-5 rating scale...i don't think that would work
additionally, the new images are twice as wide as the old ones.

Yes of course, I mistakenly thought everything was already converted to 10 ratings. Sry for noise.

@ronie ronie merged commit d34a34d into xbmc:master Sep 11, 2016
@MartijnKaijser
Copy link
Member

/offtopic
Maybe we should make the subtitle ratings also 0-10 for consistency?

@ronie ronie deleted the estuary-fixes branch October 15, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Skin Type: Fix non-breaking change which fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants