Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Estuary] bugfixes #10442

Merged
merged 11 commits into from Sep 11, 2016

Conversation

@ronie
Copy link
Member

commented Sep 9, 2016

10 fixes for issues reported here:
http://forum.kodi.tv/showthread.php?tid=262373

and there (team only):
https://github.com/xbmc/skin.estuary/issues

will squash after review

@BigNoid

This comment has been minimized.

Copy link
Member

commented Sep 11, 2016

Looks good to me. We can probably get rid of the old rating flags completely with BigNoid@2d7c3e1

@ronie ronie force-pushed the ronie:estuary-fixes branch from edd6444 to 35be856 Sep 11, 2016

@ronie

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2016

@BigNoid but subtitles use a 0-5 rating scale...i don't think that would work
additionally, the new images are twice as wide as the old ones.

@BigNoid

This comment has been minimized.

Copy link
Member

commented Sep 11, 2016

but subtitles use a 0-5 rating scale...i don't think that would work
additionally, the new images are twice as wide as the old ones.

Yes of course, I mistakenly thought everything was already converted to 10 ratings. Sry for noise.

@ronie ronie merged commit d34a34d into xbmc:master Sep 11, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 11, 2016

/offtopic
Maybe we should make the subtitle ratings also 0-10 for consistency?

@ronie ronie deleted the ronie:estuary-fixes branch Oct 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.