Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoPlayer: handle exceptional case where distance between keyframes… #10516

Merged
merged 2 commits into from
Sep 20, 2016

Conversation

FernetMenta
Copy link
Contributor

The user who created http://trac.kodi.tv/ticket/16911 has issues with self encoded videos. The distance between keyframes is chosen much to large, 240 frames. For 24fps that results in 10 seconds while demux queue is only 8 seconds. As a result audio queue may be full while video has still not found a key frame required to start.

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Video labels Sep 20, 2016
@FernetMenta FernetMenta added this to the Krypton 17.0-beta3 milestone Sep 20, 2016
@Jalle19
Copy link
Member

Jalle19 commented Sep 20, 2016

Does this affect situations where you pull the antenna cable while watching live TV, then insert it again after let's say 30 seconds?

@FernetMenta
Copy link
Contributor Author

Not sure what exactly you mean by "affect". The scenario you described has always been working for me using vnsi. I just tried and it is not broken with this change here.

@Jalle19
Copy link
Member

Jalle19 commented Sep 20, 2016

@FernetMenta that's all I wanted to know, thanks

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta
Copy link
Contributor Author

Android build error unrelated
Fix confirmed by http://trac.kodi.tv/ticket/16911#comment:17

@FernetMenta FernetMenta merged commit e932632 into xbmc:master Sep 20, 2016
@FernetMenta FernetMenta deleted the 16911 branch September 20, 2016 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants