increase property and variable ranges for skins #10527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronie
added
Type: Fix
|
@ronie, thank you for improving kodi! According to the last 5 commits, we found the potential reviewers: @phate89, @DaveTBlake and @Paxxi . Final approval needs to be given by the componenent maintainer. |
|
squashed. |
|
Perhaps add a doxygen todo comment in this location so someone looking at the code sees there's an issue to be fixed? |
|
i don't master the art of doxygen, mind checking if this is correct? |
|
Changes look OK, can't say if this will cause any performance issues though |
|
Jep looks good. Squash and merge i would say |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two commits:
1 - increase range for listitem properties by @phil65
this is not a fix, but a workaround for a bug that would really need fixing!!!1!
for discussion, please see: #8922
2 - increase range for variables
we currently 'only' reserve 500 places for skin variables (this used to be 1000 when the feature was introduced) and some skins are hitting (or exceeding) this limit.
as a result these skins pretty much get crippled after a few minutes of use.
this commit restores the reserved range for variables back to the original value of 1000.
see: http://forum.kodi.tv/showthread.php?tid=288287