Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album Record Label and Type from music files tags #10573

Merged
merged 2 commits into from Oct 1, 2016

Conversation

@DaveTBlake
Copy link
Member

commented Sep 27, 2016

Albums have label and type fields that can currently only be filled by scraping from NFO files and maybe from online sources (?). Yet music files can be tagged with record label and release type information that could be used to populate these fields.

This adds processing of the LABEL (TPUB) and RELEASETYPE (MUSICBRAINZ ALBUM TYPE) tags and uses them to poplate the album library data. Both label and type fields are avaliable in smart playlist rules, so this extends the way that users can explore their music collection.

Note the album table also has a "releasetype" field, this is used internally to flag if the entry in the album table is a real "album" or a "single" e.g. a fake album created to cover all the singles by that artist. We must take care not to confuse the two.

DaveTBlake added 2 commits Sep 27, 2016
…ote not the same as album.strRreleaseType that is used internally to flag the fake album entry used for singles)
@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 27, 2016

No db bump?

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Sep 27, 2016

If this is no fix, and I don't see the fix label, I suggest to remove the Krypton label. DB changes are always risky and should be avoided on short final

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Sep 27, 2016

i don't see short final happening soon with current issues popping up

@FernetMenta

This comment has been minimized.

Copy link
Member

commented Sep 27, 2016

we can focus on current issues and try to resolve them. if some of us try and others use this time to throw new risky code in, we'll never get somewhere.
we did agree on fixes only on devcon, didn't we?

@DaveTBlake

This comment has been minimized.

Copy link
Member Author

commented Sep 27, 2016

No db change needed guys, the data is already in the structure we just aren't filling it. Could call that a broken thing and this a fix rather than an improvement.

No risky code changes either, I know better than that for beta.

@DaveTBlake DaveTBlake merged commit 6934074 into xbmc:master Oct 1, 2016
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@DaveTBlake DaveTBlake added this to the Krypton 17.0-beta3 milestone Oct 1, 2016
@DaveTBlake DaveTBlake deleted the DaveTBlake:AlbumTypeFromTag branch Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.