Album Record Label and Type from music files tags #10573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ote not the same as album.strRreleaseType that is used internally to flag the fake album entry used for singles)
DaveTBlake
added
Type: Improvement
|
No db bump? |
|
If this is no fix, and I don't see the fix label, I suggest to remove the Krypton label. DB changes are always risky and should be avoided on short final |
|
i don't see short final happening soon with current issues popping up |
|
we can focus on current issues and try to resolve them. if some of us try and others use this time to throw new risky code in, we'll never get somewhere. |
|
No db change needed guys, the data is already in the structure we just aren't filling it. Could call that a broken thing and this a fix rather than an improvement. No risky code changes either, I know better than that for beta. |
This was referenced Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Albums have label and type fields that can currently only be filled by scraping from NFO files and maybe from online sources (?). Yet music files can be tagged with record label and release type information that could be used to populate these fields.
This adds processing of the LABEL (TPUB) and RELEASETYPE (MUSICBRAINZ ALBUM TYPE) tags and uses them to poplate the album library data. Both label and type fields are avaliable in smart playlist rules, so this extends the way that users can explore their music collection.
Note the album table also has a "releasetype" field, this is used internally to flag if the entry in the album table is a real "album" or a "single" e.g. a fake album created to cover all the singles by that artist. We must take care not to confuse the two.