Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix CPVRDirectory::GetDirectory not to return false in case PVR is not yet (compeletely started). #10613

Merged
merged 1 commit into from Oct 3, 2016

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 3, 2016

Fixes log spam on Kodi startup:

21:49:43 T:2984   ERROR: XFILE::CDirectory::GetDirectory - Error getting pvr://channels/tv/*?view=lastplayed
21:49:43 T:2984   ERROR: XFILE::CDirectory::GetDirectory - Error getting pvr://recordings/tv/active?view=flat
21:49:43 T:2984   ERROR: XFILE::CDirectory::GetDirectory - Error getting pvr://channels/radio/*?view=lastplayed
21:49:43 T:2984   ERROR: XFILE::CDirectory::GetDirectory - Error getting pvr://recordings/radio/active?view=flat

GetDirectory return value semantics is "successfully handed" which can be different from "successfully read directory content". ;-)

This is actually a regression I introduced while working on the new pvr home screen widgets.

@Jalle19 mind taking a look at the code change.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR v17 Krypton labels Oct 3, 2016
@ksooo ksooo added this to the Krypton 17.0-beta3 milestone Oct 3, 2016
@mention-bot
Copy link

@ksooo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @opdenkamp, @AlwinEsch and @xhaggi to be potential reviewers.

Copy link
Member

@xhaggi xhaggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@ksooo
Copy link
Member Author

ksooo commented Oct 3, 2016

Jenkins build this please

@ksooo ksooo merged commit ab4133c into xbmc:master Oct 3, 2016
@ksooo ksooo deleted the pvr-fix-startup-getdirectory-errors branch October 3, 2016 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants