Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MediaSettings] - fixed loading interlacemode_none from defaultsettings #10677

Merged
merged 1 commit into from Oct 12, 2016
Merged

[MediaSettings] - fixed loading interlacemode_none from defaultsettings #10677

merged 1 commit into from Oct 12, 2016

Conversation

Memphiz
Copy link
Member

@Memphiz Memphiz commented Oct 10, 2016

I think this is a leftover from this:

25718f4

Reproduction:

  1. Play an interlaced movie
  2. Disable deinterlacing
  3. Hit "save for all media"
  4. Restart kodi
  5. see how deinterlace mode is reset to something != none

The problem was the minvalue of loading interlace mode from defaultsettings was set to interlace_auto (instead of interlace_none)

@FernetMenta i think this wasn't left that way by intention right?

@Memphiz
Copy link
Member Author

Memphiz commented Oct 12, 2016

@FernetMenta objections?

@FernetMenta
Copy link
Contributor

+1 thanks

@Memphiz Memphiz merged commit 0d84570 into xbmc:master Oct 12, 2016
@Memphiz Memphiz deleted the fix_nointerlace_defaultsettings branch October 12, 2016 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Settings Component: Video Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-beta4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Memphiz @FernetMenta @MartijnKaijser