smart playlists: fix drill down from artists lists that have role based rules #10700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an "artists" type smart playlist has role rules e.g. "artist is composer", then clicking on a composer from such an artist list can result in nothing being displayed despite the fact thay they do compose some songs. This is because the role rule is not passed down to the subsequent list of albums or songs.
This is a minimal change to ensure that such incorrect blank lists are avoided.
An attempt to solve the more general problems caused by the rules from smart playlists not being passed on to the next level when an item in a list is clicked is made in #10098 . But it is probably now too late in the release cycle for such a design change, and I think there is more to be done. Hence this fix is just a stop gap to provide at least minimal functionality.