Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
smart playlists: fix drill down from artists lists that have role based rules #10700
If an "artists" type smart playlist has role rules e.g. "artist is composer", then clicking on a composer from such an artist list can result in nothing being displayed despite the fact thay they do compose some songs. This is because the role rule is not passed down to the subsequent list of albums or songs.
This is a minimal change to ensure that such incorrect blank lists are avoided.
An attempt to solve the more general problems caused by the rules from smart playlists not being passed on to the next level when an item in a list is clicked is made in #10098 . But it is probably now too late in the release cycle for such a design change, and I think there is more to be done. Hence this fix is just a stop gap to provide at least minimal functionality.
This just needs a sanity check, anyone?
The kind of smart playlist that would list artists, but then nothing beneath when you click on one is like this for composers. You need some music files in your library that have composer tagged, and the composer not an album or song artist.