Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix playing video in slideshow, fullscreen video not allowed in modal… #10720

Merged
merged 5 commits into from Oct 18, 2016

Conversation

FernetMenta
Copy link
Contributor

fix http://trac.kodi.tv/ticket/16792

@phil65 @BigNoid @ronie
In addition window MyPic needs a video control or it can't show videos in slide show. Currently the window only displays thumbs.

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Picture labels Oct 17, 2016
@FernetMenta FernetMenta added this to the Krypton 17.0-beta4 milestone Oct 17, 2016
@FernetMenta
Copy link
Contributor Author

jenkins build this please

@@ -990,11 +990,11 @@
<control type="videowindow">
<depth>DepthBackground</depth>
<include>FullScreenDimensions</include>
<visible>Player.HasVideo</visible>
<visible>Player.HasVideo + !Slideshow.IsActive</visible>

This comment was marked as spam.

This comment was marked as spam.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@ronie
Copy link
Member

ronie commented Oct 17, 2016

could you add this one as well
ronie@9ac7493

@FernetMenta
Copy link
Contributor Author

@ronie will do
btw: there is a similar issue in confluence MyPVRChannels.xml. video is rendered twice when this window is active because background is included.

now I know why the minimized view always required so many resources and made video stutter.

@ronie
Copy link
Member

ronie commented Oct 17, 2016

btw: there is a similar issue in confluence MyPVRChannels.xml. video is rendered twice when this window is active because background is included.

^ @HitcherUK

i'll post a heads-up in the skin dev forum, pretty sure every skin has similar issues.

@FernetMenta
Copy link
Contributor Author

jenkins build this please

@FernetMenta FernetMenta merged commit 4778b5f into xbmc:master Oct 18, 2016
@FernetMenta FernetMenta deleted the slide branch October 18, 2016 06:54
@Hitcher
Copy link
Contributor

Hitcher commented Oct 21, 2016

btw: there is a similar issue in confluence MyPVRChannels.xml. video is rendered twice when this window is active because background is included.
^ @HitcherUK

i'll post a heads-up in the skin dev forum, pretty sure every skin has similar issues.

@FernetMenta Are you sure this is the case because checking the code for background video has this condition in it -

<visible>Player.HasVideo + !Skin.HasSetting(ShowBackgroundVideo) + !Window.IsVisible(TVChannels) + !Window.IsVisible(RadioChannels)</visible>

@FernetMenta
Copy link
Contributor Author

@HitcherUK seems I missed this. Then it should be ok, though not really nice having the background dependent on particular windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Picture Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants