New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix playing video in slideshow, fullscreen video not allowed in modal… #10720
Conversation
jenkins build this please |
@@ -990,11 +990,11 @@ | |||
<control type="videowindow"> | |||
<depth>DepthBackground</depth> | |||
<include>FullScreenDimensions</include> | |||
<visible>Player.HasVideo</visible> | |||
<visible>Player.HasVideo + !Slideshow.IsActive</visible> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
jenkins build this please |
could you add this one as well |
@ronie will do now I know why the minimized view always required so many resources and made video stutter. |
^ @HitcherUK i'll post a heads-up in the skin dev forum, pretty sure every skin has similar issues. |
jenkins build this please |
@FernetMenta Are you sure this is the case because checking the code for background video has this condition in it -
|
@HitcherUK seems I missed this. Then it should be ok, though not really nice having the background dependent on particular windows. |
fix http://trac.kodi.tv/ticket/16792
@phil65 @BigNoid @ronie
In addition window MyPic needs a video control or it can't show videos in slide show. Currently the window only displays thumbs.