Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VideoPlayer] FFmpegDemux: proper flush io context. #10722

Merged
merged 1 commit into from Oct 18, 2016
Merged

[VideoPlayer] FFmpegDemux: proper flush io context. #10722

merged 1 commit into from Oct 18, 2016

Conversation

afedchin
Copy link
Member

see title.

@FernetMenta ping

FernetMenta
FernetMenta reviewed Oct 17, 2016
View reviewed changes
xbmc/cores/VideoPlayer/DVDDemuxers/DVDDemuxFFmpeg.cpp
@@ -581,6 +581,9 @@ void CDVDDemuxFFmpeg::Reset()

void CDVDDemuxFFmpeg::Flush()
{
if (m_ioContext)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@FernetMenta
Copy link
Contributor

thanks, looks good now

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta4 milestone Oct 17, 2016
@MartijnKaijser MartijnKaijser added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Video labels Oct 17, 2016
@afedchin
Copy link
Member Author

now it better

@FernetMenta
Copy link
Contributor

but the comment 2 lines above is outdated and wrong. those are no internal function anymore

@afedchin
Copy link
Member Author

should we just drop the comment?

@FernetMenta
Copy link
Contributor

yes please

@afedchin
Copy link
Member Author

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 4f40e93 into xbmc:master Oct 18, 2016
@afedchin afedchin deleted the ffmpeg_flush branch October 18, 2016 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FernetMenta FernetMenta FernetMenta left review comments

Assignees
No one assigned
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-beta4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@afedchin @FernetMenta @MartijnKaijser @jenkins4kodi