VideoPlayer: ffmpeg, fix calculating aspect ratio for 3d modes #10727
Conversation
FernetMenta
added
Type: Fix
|
thanks. will test this tonight. |
| @@ -833,7 +833,13 @@ bool CDVDVideoCodecFFmpeg::GetPictureCommon(DVDVideoPicture* pDvdVideoPicture) | |||
| aspect_ratio = av_q2d(pixel_aspect) * pDvdVideoPicture->iWidth / pDvdVideoPicture->iHeight; | |||
|
|
|||
| if (aspect_ratio <= 0.0) | |||
| { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I can't test with all my samples, but seems with this an anamorph video is displayed wrong.
|
|
here is a sample https://www.dropbox.com/s/q5y3q4jee30y4hx/3d.sbs.disney_3d_global_sizzle_2012-DWEU.m2ts?dl=0 which doesn't work with this |
|
with this afedchin@3989890 I have correct aspect for anamorph and full stereo. as I said above I will test with more samples tonight. |
|
your sample does not have stereo_mode set by ffmpeg. stereo_mode is set by CStereoscopicsManager::DetectStereoModeByString. |
|
but we support both stereo flags from a container and file naming convention. |
|
but the one form file naming must not be used to determine aspect ratio. PR is updated. |
|
this https://www.dropbox.com/s/an8v07r1t3k0e9h/3d.Kodi.test.mkv?dl=0 sample (anamorph stereo) still not work as expected. |
|
@afedchin I looked into ffmpeg code and noticed that AR already observes stereo modes. All samples I got work with this change. |
|
after quick test seems it returns pre ffmpeg 3.x behavior |
|
great, thanks jenkins build this please |
finally fix http://trac.kodi.tv/ticket/16876