Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable debug in depends in Release builds #10728

Merged
merged 2 commits into from
Oct 21, 2016
Merged

Conversation

wsnipex
Copy link
Member

@wsnipex wsnipex commented Oct 19, 2016

as discussed on slack, should fix ugly asserts (e.g. in pil) in Release builds

@wsnipex wsnipex added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Depends labels Oct 19, 2016
@wsnipex
Copy link
Member Author

wsnipex commented Oct 19, 2016

jenkins build this please

@Paxxi
Copy link
Member

Paxxi commented Oct 19, 2016

Thank you for fixing this, can't really say much about the actual changes.

@wsnipex
Copy link
Member Author

wsnipex commented Oct 20, 2016

jenkins build this please

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta4 milestone Oct 20, 2016
@MartijnKaijser
Copy link
Member

Triggered release build to test as well
http://jenkins.kodi.tv/view/Helpers/job/BuildMulti-All/1672/

@MartijnKaijser
Copy link
Member

@wsnipex it runs fine on aarch64

@wsnipex
Copy link
Member Author

wsnipex commented Oct 21, 2016

thanks for testing

@wsnipex wsnipex merged commit 757f8db into xbmc:master Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Depends Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants