Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] Fix build with VAAPI/VDPAU off on linux #10729

Merged
merged 1 commit into from Oct 19, 2016
Merged

[cmake] Fix build with VAAPI/VDPAU off on linux #10729

merged 1 commit into from Oct 19, 2016

Conversation

hudokkow
Copy link
Member

Description

Motivation and Context

Fix http://trac.kodi.tv/ticket/16706

How Has This Been Tested?

Briefly runtime tested.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@hudokkow hudokkow added Type: Fix non-breaking change which fixes an issue v17 Krypton Platform: Linux CMake labels Oct 19, 2016
@hudokkow hudokkow added this to the Krypton 17.0-beta4 milestone Oct 19, 2016
@hudokkow
Copy link
Member Author

jenkins build this please

fetzerch
fetzerch reviewed Oct 19, 2016
View reviewed changes
xbmc/cores/VideoPlayer/VideoRenderers/HwDecRender/CMakeLists.txt
core_add_library(videorenderers_hwdec)
# we might want to build on linux systems
# with ENABLE_VDPAU=OFF and ENABLE_VAAPI=OFF
if(CORE_SYSTEM_NAME STREQUAL linux AND NOT VDPAU_FOUND AND NOT VAAPI_FOUND)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@hudokkow
Copy link
Member Author

jenkins build this please

@hudokkow hudokkow merged commit d73fbb1 into xbmc:master Oct 19, 2016
@hudokkow hudokkow deleted the cmake_fix_vaapi_vdpau_off branch October 19, 2016 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fetzerch fetzerch fetzerch left review comments

Assignees
No one assigned
Labels
CMake Platform: Linux Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-beta4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hudokkow @fetzerch