Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Change splash db upgrade logic #10731
Change the splash screen to show the message of upgrading database only when we're actually upgrading a database.
Motivation and Context
The old method wassn't aware if there was some upgrade and what db was doing the upgrade
How Has This Been Tested?
Tested upgrading my old mysql databases
Screenshots (if appropriate):
Types of change
Thanks @phate89 - it works well, I've tested upgrading MyMusic50 to MyMusic60 and MyVideos90 to MyVideos107, the latter is particularly time consuming. I'll include this PR in future builds.
There does however remain one issue: when
IMHO the splash should be forced to appear along with the migration messages, regardless of the
One other nitpick would be to position the text a little higher, just in case of any overscanning or weird resolution issues - it seems a little unnecessary to position the text quite so low down (it appears to be close to the bottom edge of my 1920x1080 1:1 pixel screen).
Sorry but not liking how this is currently implemented. The database should not have a dependency on the global application messenger. Instead it should be passed in as a callback/another agnostic structure, or the entire migration refactored and uncoupled from the database. This is why I didn't bothered with it in the first place.
@tamland trust that passing in a callback could be cleaner but more work. This is a step in the right direction and app messenger is purposely designed for this with very few dependencies itself.
@FernetMenta thanks for the suggestions. Any help is appreciated.