[CMAKE] - fixups for ios/binaddons #10732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - this enables the cmake cross compile flag which will be needed in cmake 3.7 to fix an ugly bug with osx sdk flags spreading into the ios cflags during cross compile
|
Jenkins build and merge |
MartijnKaijser
added
v17 Krypton
Platform: macOS
Platform: iOS
CMake
and removed
Platform: macOS
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those are some fixes which i found during building with cmake 3.6 for tvos on our jenkins slave which triggered a bug due to sdk/osx host version constellation. I filed a bug report on cmake and it will be fixed in cmake 3.7 - those commits from this PR are needed in addition.
@fetzerch for review