Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMAKE] - fixups for ios/binaddons #10732

Merged
merged 2 commits into from Oct 20, 2016

Conversation

@Memphiz
Copy link
Member

commented Oct 19, 2016

Those are some fixes which i found during building with cmake 3.6 for tvos on our jenkins slave which triggered a bug due to sdk/osx host version constellation. I filed a bug report on cmake and it will be fixed in cmake 3.7 - those commits from this PR are needed in addition.

@fetzerch for review

Memphiz added 2 commits Oct 19, 2016
… - this enables the cmake cross compile flag which will be needed in cmake 3.7 to fix an ugly bug with osx sdk flags spreading into the ios cflags during cross compile
Copy link
Member

left a comment

LGTM :)

@Memphiz

This comment has been minimized.

Copy link
Member Author

commented Oct 20, 2016

Jenkins build and merge

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta4 milestone Oct 20, 2016
@jenkins4kodi jenkins4kodi merged commit 0c92390 into xbmc:master Oct 20, 2016
1 of 4 checks passed
1 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
default I've found some spare time so building this now
Details
jenkins4kodi Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.