Use new add-on hooks to enable/disable peripheral add-ons #10734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves on the fix in PR 10690 by avoiding the broken add-on hooks and relying on the new pub/sub functionality for add-ons.
|
@tamland how's this look? |
|
good. it was already implemented (..?) It's also possible to get the addon id from those event btw; if you want avoid running the whole 'UpdateAddons' |
|
k, thanks for the feedback. gotta love when you go to fix something and it's already implemented :) the problem was that we weren't listening for enable/disable, just install, so that's why enable/disable had no immediate effect in the gui. Adding enable/disable events fixed this. jenkins build this please |
MartijnKaijser
added
Type: Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on #10690 by avoiding the old hooks and using the new ones that @tamland added