Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [amc] Multiple fixes #10779

Merged
merged 5 commits into from Oct 30, 2016
Merged

FIX: [amc] Multiple fixes #10779

merged 5 commits into from Oct 30, 2016

Conversation

koying
Copy link
Contributor

@koying koying commented Oct 26, 2016

Description

Mutiple Mediacodec fixes

Motivation and Context

Should fix the "freeze when seeking" symptom

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@MartijnKaijser
Copy link
Member

jenkins build and merge

@koying koying force-pushed the fixamcfreeze branch 2 times, most recently from e39bfe7 to 2a2b21a Compare October 27, 2016 13:08
@Erikson
Copy link

Erikson commented Oct 28, 2016

Hi, what happend to the merge? I also have the "freeze when seeking" symptom on the fire tv stick and hoped for this fix. :)

@MartijnKaijser
Copy link
Member

@Erikson fix is not complete so merge was cancelled. Please stick to the forum for questions.

@koying koying changed the title FIX: [amc] return correct pts when dropping FIX: [amc] Multiple fixes Oct 29, 2016
@koying
Copy link
Contributor Author

koying commented Oct 29, 2016

@MartijnKaijser Cleaned-up
jenkins build this please

@@ -679,7 +680,7 @@ int CDVDVideoCodecAndroidMediaCodec::Decode(uint8_t *pData, int iSize, double dt
// Handle input, add demuxer packet to input queue, we must accept it or
// it will be discarded as VideoPlayerVideo has no concept of "try again".
// we must return VC_BUFFER or VC_PICTURE, default to VC_BUFFER.
int rtn = (m_state == MEDIACODEC_STATE_BEFORE_ENDOFSTREAM || m_state == MEDIACODEC_STATE_ENDOFSTREAM) ? 0 : VC_BUFFER;
m_dec_retcode = (m_state == MEDIACODEC_STATE_BEFORE_ENDOFSTREAM || m_state == MEDIACODEC_STATE_ENDOFSTREAM) ? 0 : VC_BUFFER;

This comment was marked as spam.

This comment was marked as spam.

Copy link
Member

@MartijnKaijser MartijnKaijser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the video stalls i've been seeing past time

@ghost
Copy link

ghost commented Oct 30, 2016

could i get a arm test build please im having issues on resume on files it black screens and then wont load anything at all i need to reboot my tv, restarting kodi doesnt help, 5 reboots in 2 days.

@MartijnKaijser MartijnKaijser merged commit 6d4d9bf into xbmc:master Oct 30, 2016
@MartijnKaijser
Copy link
Member

@Mazeyx http://mirrors.kodi.tv/test-builds/android/arm/kodi-20161028-985ce8b-fixamcfreeze-armeabi-v7a.apk or tomorrows nightly build.
Please report any further problems on the forum with debuglogs and logcat if possible

@ghost
Copy link

ghost commented Oct 30, 2016

@MartijnKaijser thx will give it a whirl now will see if it does it again, ill try trigger it if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants