Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide passwords from advancedsettings log #10790

Merged
merged 1 commit into from Oct 31, 2016
Merged

Hide passwords from advancedsettings log #10790

merged 1 commit into from Oct 31, 2016

Conversation

phate89
Copy link
Contributor

@phate89 phate89 commented Oct 27, 2016 •
edited

Hide passwords when we dump advancedsettings in the log.

Motivation and Context

Right now we dump passwords from advancedsettings in our log

How Has This Been Tested?

I tested it with my advancedsettings file

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@hudokkow
Copy link
Member

Fixes http://trac.kodi.tv/ticket/16968

@hudokkow
Copy link
Member

jenkins build this please

@phate89 phate89 added Type: Fix non-breaking change which fixes an issue v17 Krypton labels Oct 27, 2016
@hudokkow
Copy link
Member

hudokkow commented Oct 27, 2016 •
edited

I can find one more place that could benefit from this. See httpproxypassword in http://kodi.wiki/view/advancedsettings.xml#network

Confimed working in linux.

@phate89 phate89 changed the title Hide mysql passwords from advancedsettings log Hide passwords from advancedsettings log Oct 27, 2016
@phate89
Copy link
Contributor Author

phate89 commented Oct 27, 2016

I missed that. thanks. Updated.
jenkins build this please

@phate89
Copy link
Contributor Author

phate89 commented Oct 27, 2016

jenkins build this please

@MartijnKaijser
Copy link
Member

@Montellese ping

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta6 milestone Oct 28, 2016
@MartijnKaijser
Copy link
Member

jenkins build this please

@phate89
Copy link
Contributor Author

phate89 commented Oct 29, 2016

weird.. android build couldn't git the commit..
Is this pr okay?
jenkins build this please

@phate89
Copy link
Contributor Author

phate89 commented Oct 30, 2016

jenkins build this please

@phate89 phate89 merged commit 5d70fe0 into xbmc:master Oct 31, 2016
@phate89 phate89 deleted the hide_mysql_pass branch November 30, 2016 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnKaijser MartijnKaijser MartijnKaijser approved these changes

Assignees
No one assigned
Labels
Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-beta6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phate89 @hudokkow @MartijnKaijser