VideoPlayer: hls, select best resolution closest to desired bandwidth #10801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
added
Type: Fix
|
Yes, fixes the URL. However now playing that URL takes between 6 and 12 seconds to start stream. Any reason why it's much slower? |
|
It is much faster here on my Mac. Stream also starts within 1-2 secs. The old function did parse the m3m8 playlist file to select a particular url. But it did not properly and as a result on some playlists audio was missing. Now we let ffmpeg do this. Maybe the self-selected stream was identified as mpegts and demuxer used the "fast-channel-switch" path by reducing time for analysis in find_stream_info. jenkins build this please |
|
good for merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see title
@popcornmix that fixes the issue for the url you gave me