Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Debug binary-addon packaging issues on android #10803

Merged
merged 2 commits into from Oct 30, 2016

Conversation

@fetzerch
Copy link
Member

fetzerch commented Oct 29, 2016

Description

Adds more log output to debug the current issue that sometimes binary-addons are not packaged on android. The second commit needs to be reverted once the issue is sorted out.
http://trac.kodi.tv/ticket/17033#ticket

Motivation and Context

Get it included in more builds as it's a heisenbug and didn't show up in 5 manually triggered builds.

How Has This Been Tested?

Locally and on Jenkins. Doesn't change behavior, just adds more logging.

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed
fetzerch added 2 commits Oct 10, 2016
…ing failures

This commit should be reverted once the issue is understood and
resolved.
@fetzerch fetzerch force-pushed the fetzerch:cmake_adddbg branch from ec2e06f to 978b8ee Oct 29, 2016
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta6 milestone Oct 30, 2016
@wsnipex

This comment has been minimized.

Copy link
Member

wsnipex commented Oct 30, 2016

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 96fe9d1 into xbmc:master Oct 30, 2016
2 of 4 checks passed
2 of 4 checks passed
default I've found some spare time so building this now
Details
jenkins4kodi Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fetzerch fetzerch deleted the fetzerch:cmake_adddbg branch Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.