Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: [amcs] get proper VideoView size (fixes #17032) #10818

Merged
merged 1 commit into from Oct 31, 2016
Merged

FIX: [amcs] get proper VideoView size (fixes #17032) #10818

merged 1 commit into from Oct 31, 2016

Conversation

koying
Copy link
Contributor

@koying koying commented Oct 30, 2016

Description

FIX: [amcs] get proper VideoView size (fixes #17032)

Motivation and Context

Current code does not take the right window size into account for Surface, leading to not-fullscreen playback on phones with soft-buttons

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@MartijnKaijser MartijnKaijser added Type: Fix non-breaking change which fixes an issue Component: Video Platform: Android labels Oct 30, 2016
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta6 milestone Oct 30, 2016
@MrMC
Copy link

MrMC commented Oct 30, 2016

nice :)

@koying
Copy link
Contributor Author

koying commented Oct 31, 2016

jenkins build this please

@koying
Copy link
Contributor Author

koying commented Oct 31, 2016

Confirmed fixing the bug by reporter

@MartijnKaijser MartijnKaijser merged commit 20d744c into xbmc:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Video Platform: Android Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-beta6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@koying @MrMC @MartijnKaijser