Fixed: RTMP swfvfy also accepts 1 instead of just true #10820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FernetMenta
added
Type: Fix
|
thanks! |
|
jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out that SWFVFY=1 will break RTMP playback on Kodi 17.x. The documentation at http://rtmpdump.mplayerhq.hu/librtmp.3.html does show it as a valid option.
Motivation and Context
Currently it breaks backward compatibility and if a user goes to the RTMP documentation, they will find a value for swfvfy that will not work with Kodi.
How Has This Been Tested?
I compiled and tested with my add-on (Retrospect http://www.rieter.net/content/xot/downloads/) by playing a stream from the "Nickelodeon (Sverige)" channel (from the 'Big Time Rush' show).
Types of change
Just single new or statement added.
Checklist: