Revert "Picture: Use av_malloc when using ffmpeg scalers" #10826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aadfc21.
|
Thanks @akva2 for pinging me. |
|
jenkinds build and merge |
MartijnKaijser
added
Type: Fix
|
@akva2 can you please revert the other commit with av's malloc and free or remove the & before the argument of av_free? |
|
Other fix on the way. |
MartijnKaijser
modified the milestones:
Abandoned, obsolete or superseeded,
Krypton 17.0-beta6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in a hurry, that broke Pictures. I need to have a look after being back.
Remember: It's not safe to put custom buffers into ffmpeg methods, cause they don't have proper alignment. With the above original code - it happened the other way round :-)