Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: used av_free when av_freep was intended in f5f9b8d and aadfc21d #10828

Merged
merged 2 commits into from Oct 31, 2016

Conversation

notspiff
Copy link
Contributor

proxying for @fritsch

@notspiff
Copy link
Contributor Author

hold al ittle i'm seeing issues again

@hudokkow hudokkow added Type: Fix non-breaking change which fixes an issue v17 Krypton Component: Picture labels Oct 31, 2016
@hudokkow
Copy link
Member

Ping when ready!

@fritsch
Copy link
Member

fritsch commented Oct 31, 2016

Thx much. Please plain revert the Pic commit,please. These buffers are freed elsewhere. Need to track down when back.

Thanks again for helping out.

@notspiff
Copy link
Contributor Author

there we go.

@hudokkow
Copy link
Member

@fritsch, which is it? plain revert or spiff's work?

@fritsch
Copy link
Member

fritsch commented Oct 31, 2016

spiff's work, please!

@hudokkow
Copy link
Member

Okido. Thx spiff.
jenkins build and merge

@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta6 milestone Oct 31, 2016
@jenkins4kodi jenkins4kodi merged commit e67aa1a into xbmc:master Oct 31, 2016
@notspiff notspiff deleted the fix_avfree_p branch October 31, 2016 12:00
@phate89
Copy link
Contributor

phate89 commented Nov 6, 2016

@notspiff we found that this image crashes kodi after your and @fritsch prs
http://trac.kodi.tv/attachment/ticket/17058/ocVGlJcYQMAv5dJymNrWnTHVj2M.jpg

@fritsch
Copy link
Member

fritsch commented Nov 8, 2016

Will fix after I am back. Btw does add a 1px border to the right fix it?

Am 06.11.2016 5:14 nachm. schrieb "phate89" notifications@github.com:

we found that this image crashes kodi after your and fritsch prs
[image: ocvgljcyqmav5djymnrwnthvj2m]
https://cloud.githubusercontent.com/assets/1254959/20039887/c8a13cd0-a44c-11e6-897d-7934418dc123.jpg


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10828 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABCfHW3T_ywXSIMJf4WKs4deif0Q8JJsks5q7grkgaJpZM4Kk4o2
.

@phate89
Copy link
Contributor

phate89 commented Nov 8, 2016

yes works with resolution
256x255
1969x2349

but crashes with
1968x2349

@fritsch
Copy link
Member

fritsch commented Nov 8, 2016

You sure the last two are right?

I'd say 1968 works but 1969 (original image) not. Right?

Am 08.11.2016 1:14 nachm. schrieb "phate89" notifications@github.com:

yes works with resolution
256x255
1969x2349

but crashes with
1968x2349


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#10828 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABCfHbv2BzQyBoZpnkIM2HRvqapDRHT0ks5q8HWogaJpZM4Kk4o2
.

@phate89
Copy link
Contributor

phate89 commented Nov 8, 2016

No the original image is 1968 and crashes..you asked to add a pixel to the right and it works (1969)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Picture Type: Fix non-breaking change which fixes an issue v17 Krypton
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants