Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PVR] Fix local art lookup log spam. pvr recordings never have local art. #10832

Merged
merged 1 commit into from Nov 1, 2016

Conversation

@ksooo
Copy link
Member

commented Oct 31, 2016

Estuary's new "recently recordings" widget my cause serious kodi.log spamming due to attempts to obtain local (fan)art for PVR recordings - which never is possible.

For every recording, (at least?) 3 log warnings are written:

2016-10-31 19:56:15.202542 Kodi[32146:857701] Debug Print: CreateLoader - unsupported protocol(pvr) in pvr://recordings/tv/active/Kauniit ja rohkeat/Kauniit ja rohkeat (S) Steffy kakkosveljen kainalossa. Steffy on pettynyt sulhaseensa, mutta yrittää silti vastustella Wyattin hempeitä lemmenkutsuja. Nicole ei pidä siitä, että Zende inspiroituu muista naisista. Amerikkalainen saippuasarja., TV (MTV3 HD), 20161031_152500, 1894834710-poster.jpg
2016-10-31 19:56:31.563713 Kodi[32146:857701] Debug Print: CreateLoader - unsupported protocol(pvr) in pvr://recordings/tv/active/Kauniit ja rohkeat/Kauniit ja rohkeat (S) Steffy kakkosveljen kainalossa. Steffy on pettynyt sulhaseensa, mutta yrittää silti vastustella Wyattin hempeitä lemmenkutsuja. Nicole ei pidä siitä, että Zende inspiroituu muista naisista. Amerikkalainen saippuasarja., TV (MTV3 HD), 20161031_152500, 1894834710-poster.png
2016-10-31 19:56:35.824451 Kodi[32146:857701] Debug Print: CreateLoader - unsupported protocol(pvr) in pvr://recordings/tv/active/Kauniit ja rohkeat/Kauniit ja rohkeat (S) Steffy kakkosveljen kainalossa. Steffy on pettynyt sulhaseensa, mutta yrittää silti vastustella Wyattin hempeitä lemmenkutsuja. Nicole ei pidä siitä, että Zende inspiroituu muista naisista. Amerikkalainen saippuasarja., TV (MTV3 HD), 20161031_152500, 1894834710-banner.jpg

Note to @Jalle19 : look what i have taken for testing. ;-)

Fix is straight forward: skip local art lookup for pvr recordings, like it is done already for Live TV and many other type of content.

@Jalle19 mind taking a look at the code change?

Copy link
Member

left a comment

Looks sane, thanks!

@ksooo

This comment has been minimized.

Copy link
Member Author

commented Oct 31, 2016

jenkins build this please

@ksooo ksooo merged commit 08f0972 into xbmc:master Nov 1, 2016
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins4kodi You did a great job. Have a cookie.
Details
@ksooo ksooo deleted the ksooo:pvr-fix-recordings-fanart-logspam branch Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.