Picture: Partially revert f5f9b8d and aadfc21d (keeping fixes) #10906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This build fixes the issues for the windows folks. jenkins build this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picture and Texture is a great mess.
I wanted to "fix" something in a fast way, by making sure that ffmpeg methods like scale and others only run on av_malloced buffers. The problem we have is, that two things are not good in current design:
a) memory is alloced "somehow" and just given into our Image
b) memory is not deleted at a central point, but all over the places
I don't want to delay v17 any further, but this needs to change for the future by providing an encapsulated method of creating and deleting memory that we use for picture processing.