Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[addon] remove not needed header comment in CScreenSaver #10972

Merged
merged 1 commit into from
Dec 10, 2016

Conversation

AlwinEsch
Copy link
Member

The comment says 'Things that MUST be supplied by the child classes', but there
are no childs, is everything inside him.

@AlwinEsch AlwinEsch added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v17 Krypton labels Nov 22, 2016
@AlwinEsch AlwinEsch added this to the Krypton 17.0-beta7 milestone Nov 22, 2016
@AlwinEsch
Copy link
Member Author

jenkins build this please and merge

@akva2
Copy link
Contributor

akva2 commented Nov 22, 2016

childs refer to instances in the context. so it's not wrong as such, just imprecise.

@AlwinEsch
Copy link
Member Author

AlwinEsch commented Nov 22, 2016

For me the text was not understandable, to use as calls for screensaver is it clear that the rest of kodi must call them.
And for calls on add-on is it only:

  void Start();
  void Render();
  void GetInfo(SCR_INFO* pInfo);

The GetInfo becomes also removed in future, was never used in Kodi and add-ons.
EDIT: GetInfo is from me from the past with the idea to have it like PVR and to allow add from them.

@akva2
Copy link
Contributor

akva2 commented Nov 22, 2016

Not disagreeing or objecting to anything, just providing the information.

The comment on code has confused me a bit and is not really required on so small code.
To prevent misunderstand becomes it removed.
@AlwinEsch AlwinEsch changed the title [addon] remove wrong header comment of CScreenSaver [addon] remove not needed header comment in CScreenSaver Dec 1, 2016
@AlwinEsch
Copy link
Member Author

jenkins build this please

@AlwinEsch AlwinEsch merged commit b69b0f1 into xbmc:master Dec 10, 2016
@AlwinEsch AlwinEsch deleted the binary-addon-rework-part12 branch December 10, 2016 12:40
@hudokkow hudokkow added this to the L 18.0-alpha1 milestone Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants