Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GUIInfo] calculate correct remaining play time for speed up playback #11009

Merged
merged 1 commit into from
Dec 22, 2016

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Nov 29, 2016

Description

Calculate the correct remaining play time for speed up or slowed playback.

Motivation and Context

Always get the correct time during playback for Ends at: ??:?? in the GUI.

How Has This Been Tested?

Runtime tested

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

time += CDateTimeSpan(0, 0, 0, GetPlayTimeRemaining());
int playTimeRemaining = GetPlayTimeRemaining();
float speed = g_application.m_pPlayer->GetPlaySpeed();
if (speed >= 0.75 || speed <= 1.55)

This comment was marked as spam.

This comment was marked as spam.

@FernetMenta FernetMenta added Type: Fix non-breaking change which fixes an issue v18 Leia Component: Video labels Dec 22, 2016
@FernetMenta
Copy link
Contributor

thanks!
jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit fc20653 into xbmc:master Dec 22, 2016
@Rechi Rechi deleted the remainingPlayTime branch December 22, 2016 11:54
@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 22, 2016
@Rechi Rechi mentioned this pull request May 30, 2017
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants