support for image decoder add-ons #11086

notspiff · 2016-12-07T10:41:22Z

This is my work on support for image add-ons. The main motivation for this is bringing back libraw support that was lost when cximage was kicked out.

i have confirmed that decode works. you find addons in my github account (raw only for now). if you want to try the raw stuff https://www.rawsamples.ch/index.php/en/canon is convenient.

notspiff · 2016-12-07T10:43:25Z

@AlwinEsch hope this doesn't create too much problems for your refactoring effort! it should be straight forward to move to a new API like other stuff. of course, it means more work, but that's the cost of progress ;)

hudokkow · 2016-12-07T11:10:09Z

Probably should have a new component? kodi-imageencoder-dev? Something for later.

xbmc/addons/kodi-addon-dev-kit/include/kodi/kodi_imageenc_types.h

+    const char* mimetype;
+  };
+
+  struct ImageEncoder


notspiff · 2017-01-05T11:13:51Z

due to the underwhelming feedback i have taken a few executive decisions:

no support for thumbnail creation in add-ons. decode / encode cycle suffices for these (was only ever relevant for jpeg)
the factory isn't hot enough to be worth complicating. i listed a dir with 1000 raw's and the time to instance decoders was utterly irrelevant.
kodi-image-dev is a separate package

i thus renamed the extension point kodi.imagedecoder. notspiff/imagedecoder.raw for an add-on.

i also rebased for the new add-on stuff (struct table and such).

as far as i am concerned this is ready for merge.

hudokkow · 2017-01-05T12:00:50Z

CMake changes look good to me. Can't comment on the rest.
You might want to update the wording in kodi-image-dev.txt.in to match https://github.com/xbmc/xbmc/pull/11370/files

Happy New Year!

xbmc/windowing/X11/WinSystemX11.cpp

@@ -911,7 +911,8 @@ bool CWinSystemX11::CreateIconPixmap()
  gRatio = vis->green_mask / 255.0;
  bRatio = vis->blue_mask / 255.0;

-  CBaseTexture *iconTexture = CBaseTexture::LoadFromFile("special://xbmc/media/icon256x256.png");
+  CBaseTexture *iconTexture = CBaseTexture::LoadFromFile("special://xbmc/media/icon256x256.png",
+                                                         0, 0, "image/png");


fritsch · 2017-01-05T12:09:36Z

@AlwinEsch as you are currently reworking binary addon interfaces, please also have a look.

Thanks very much for doing that work. Very nice and non intrusive.

notspiff · 2017-01-05T12:15:46Z

packaging comment updated.

Paxxi · 2017-01-14T11:57:25Z

If there's no objections, rebase and merge?

hudokkow · 2017-01-14T18:39:25Z

No objections from me.

hudokkow · 2017-02-01T21:55:29Z

@AlwinEsch, any comments or can this be rebased and merged?

MartijnKaijser · 2017-02-06T16:33:44Z

can we just move forward or do we need to wait?

xbmc/addons/AddonBuilder.cpp

@@ -136,6 +138,8 @@ std::shared_ptr<IAddon> CAddonBuilder::Build()
      return CAudioEncoder::FromExtension(std::move(m_props), m_extPoint);
    case ADDON_AUDIODECODER:
      return CAudioDecoder::FromExtension(std::move(m_props), m_extPoint);
+    case ADDON_IMAGEDECODER:
+      return CImageDecoder::FromExtension(std::move(m_props), m_extPoint);


xbmc/guilib/TextureFormats.h

+#define XB_FMT_A8         32
+#define XB_FMT_RGBA8      64
+#define XB_FMT_RGB8      128
+#define XB_FMT_OPAQUE  65536


AlwinEsch · 2017-02-06T18:11:56Z

On the whole it is very good and nice.

notspiff · 2017-02-06T20:42:14Z

well, my reasoning is simply that guilib can be used without add-on support right now, the other way not so much. you will have your layer as soon as i find some time (perhaps as early as tomorrow morning if the scraper fix in my backlog doesn't eat the whole train ride).

xbmc/addons/ImageDecoder.cpp

+{
+  if (!Initialized())
+    return false;
+


notspiff · 2017-02-06T20:58:32Z

no, but sticking the header in add-on bindings, then having to include it in guilib instead would! i didn't invent these defines, i extracted them from XBTF.h to avoid the need to bring the entire XBTF.h with all its tentacles into add-on bindings. i have agreed to do the translation layer, which moves the add-on binding <- guilib dependency to add-on classes <- guilib, but i will not make the dependency guilib <- add-on bindings. can somebody who does a better job than google translate please translate this to german so nothing gets lost in translation. mine is so rusty i'd probably end up offending alwin's mum in the process ;)

notspiff · 2017-02-07T06:37:22Z

branch rebased, translation layer added, imagedecoder.raw updated.

notspiff · 2017-02-08T10:27:44Z

everybody seems happy, can we please merge so i don't have to rebase this again.

Paxxi · 2017-02-08T10:30:30Z

If anything breaks, I never touched the button! 😀

AlwinEsch · 2017-02-08T16:09:19Z

Have tested it and works nice.

Found by chance and test a good picture :D :

fritsch · 2017-02-08T16:43:05Z

Thank you very much! Am 08.02.2017 5:09 nachm. schrieb "Alwin Esch" <notifications@github.com>:

…

Have tested it and works nice. Found by chance and test a good picture :D : [image: bildschirmfoto vom 2017-02-08 16-54-35] <https://cloud.githubusercontent.com/assets/6879739/22745512/18430d2c-ee21-11e6-8e0d-256287867f52.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11086 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABCfHSr0_PzJ0lVe7wwMNsFP887baEHFks5raei0gaJpZM4LGcSI> .

Paxxi · 2017-02-08T19:05:10Z

I completely forgot about it, threw together a quick build for libraw
https://github.com/Paxxi/LibRaw builds fine but untested

notspiff · 2017-02-08T19:56:35Z

pushed a dependency definition in the add-on. untested but should be able kick an add-on build on jenkins to check thinngs.

MartijnKaijser · 2017-02-08T20:07:57Z

running now
http://jenkins.kodi.tv/job/BuildMulti-All/1908/

notspiff · 2017-02-08T20:43:09Z

damn close but somebody else keeps the sigar. mismatch in config file name. it expects RAW-config.cmake, not libraw-config.cmake. needs to be adjusted in either add-on or your repo (idc which).

Paxxi · 2017-02-08T20:52:42Z

I can fix it tomorrow, you want the whole project/target to be just raw or config enough?

notspiff · 2017-02-08T20:53:29Z

only care about config file, it needs to match the find rule in the add-on which is currently FindRAW.cmake (config file overrides, i assume you know but just in case).

Paxxi · 2017-02-09T17:06:37Z

I renamed everything to just raw, would likely just cause issues in the future having different names

notspiff force-pushed the imageencoders branch from 89ff2af to 9630cc3 Compare December 7, 2016 10:46

hudokkow added Component: Add-ons RFC PR submitted for gathering feedback v18 Leia WIP PR that is still being worked on Component: Binary add-ons labels Dec 7, 2016

AlwinEsch reviewed Dec 11, 2016

View reviewed changes

xbmc/addons/kodi-addon-dev-kit/include/kodi/kodi_imageenc_types.h Outdated

const char* mimetype;

};

struct ImageEncoder

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

notspiff force-pushed the imageencoders branch 2 times, most recently from 37cff1d to 05d83b9 Compare January 5, 2017 11:11

notspiff changed the title ~~support for image (en|de)coder add-ons~~ support for image decoder add-ons Jan 5, 2017

notspiff force-pushed the imageencoders branch from 05d83b9 to 64dbc65 Compare January 5, 2017 11:51

fritsch reviewed Jan 5, 2017

View reviewed changes

notspiff force-pushed the imageencoders branch 2 times, most recently from 7f926d5 to 6bfec3a Compare January 5, 2017 12:15

notspiff force-pushed the imageencoders branch 2 times, most recently from d0d48fc to 28029be Compare January 5, 2017 12:19

notspiff mentioned this pull request Jan 5, 2017

import imagedecoder.raw xbmc/repo-binary-addons#53

Merged

notspiff force-pushed the imageencoders branch from 28029be to a7b0865 Compare January 9, 2017 14:38

garbear mentioned this pull request Feb 1, 2017

draft of image encoders garbear/xbmc#47

Closed

AlwinEsch reviewed Feb 6, 2017

View reviewed changes

xbmc/addons/ImageDecoder.cpp

{

if (!Initialized())

return false;

This comment was marked as spam.

Sign in to view

notspiff added 4 commits February 7, 2017 07:18

add cr2, nef and arw to mime types

7c3b117

support for image decoder add-ons

45027d9

automatic addition of image extensions from addons

70acff4

add kodi-image-dev in packaging

10b4956

notspiff force-pushed the imageencoders branch from a7b0865 to 10b4956 Compare February 7, 2017 06:37

Paxxi merged commit 8fdd918 into xbmc:master Feb 8, 2017

AlwinEsch removed the WIP PR that is still being worked on label Feb 8, 2017

notspiff deleted the imageencoders branch February 8, 2017 19:56

MartijnKaijser removed the RFC PR submitted for gathering feedback label Feb 9, 2017

MartijnKaijser added this to the L 18.0-alpha1 milestone Feb 9, 2017

lrusak mentioned this pull request Feb 12, 2017

imagedecoder.raw: add add-on LibreELEC/LibreELEC.tv#1329

Merged

support for image decoder add-ons #11086

support for image decoder add-ons #11086

Conversation

notspiff commented Dec 7, 2016 • edited

notspiff commented Dec 7, 2016

hudokkow commented Dec 7, 2016

This comment was marked as spam.

This comment was marked as spam.

notspiff commented Jan 5, 2017 • edited

hudokkow commented Jan 5, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

fritsch commented Jan 5, 2017

notspiff commented Jan 5, 2017

Paxxi commented Jan 14, 2017

hudokkow commented Jan 14, 2017

hudokkow commented Feb 1, 2017

MartijnKaijser commented Feb 6, 2017

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

AlwinEsch commented Feb 6, 2017

notspiff commented Feb 6, 2017 via email

This comment was marked as spam.

notspiff commented Feb 6, 2017 via email • edited

notspiff commented Feb 7, 2017 • edited

notspiff commented Feb 8, 2017

Paxxi commented Feb 8, 2017

AlwinEsch commented Feb 8, 2017

fritsch commented Feb 8, 2017 via email

Paxxi commented Feb 8, 2017

notspiff commented Feb 8, 2017

MartijnKaijser commented Feb 8, 2017

notspiff commented Feb 8, 2017

Paxxi commented Feb 8, 2017

notspiff commented Feb 8, 2017 • edited

Paxxi commented Feb 9, 2017

notspiff commented Dec 7, 2016 •

edited

notspiff commented Jan 5, 2017 •

edited

notspiff commented Feb 6, 2017 via email •

edited

notspiff commented Feb 7, 2017 •

edited

notspiff commented Feb 8, 2017 •

edited