Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItems: Rename "emulator" property to "gameclient" #11097

Merged
merged 1 commit into from Dec 12, 2016

Conversation

@garbear
Copy link
Member

commented Dec 9, 2016

From commit description:

This change apparently got dropped in a RetroPlayer rebase. The reason is because gameclient is more generic than emulator, as the game might be a launchable asset instead of a ROM. Also, I would expect "emulator" to be a human-readable string, e.g. "PCSX Re-armed", whereas "gameclient" is more obviously an add-on ID.

I wanted to get this in ASAP before add-ons start using this value.

@@ -640,7 +640,7 @@ namespace XBMCAddon
/// | developer | string (Square)
/// | overview | string (Long Description)
/// | year | integer (1980)
/// | emulator | string (game.libretro.fceumm)
/// | gameclient | string (game.libretro.fceumm)

This comment has been minimized.

Copy link
@MartijnKaijser

MartijnKaijser Dec 10, 2016

Member

Please also add
@python_v18 Added new types **game** and associated infolabels.
or something few lines lower

This comment has been minimized.

Copy link
@garbear

garbear Dec 10, 2016

Author Member

done

@garbear garbear force-pushed the garbear:rename-listitem branch from 7239c01 to 5fefd9f Dec 10, 2016

ListItems: Rename "emulator" property to "gameclient"
This change apparently got dropped in a RetroPlayer rebase. The reason is
because gameclient is more generic than emulator, as the game might be a
launchable asset instead of a ROM. Also, I would expect "emulator" to be
a human-readable string, e.g. "PCSX Re-armed", whereas "gameclient" is
more obviously an add-on ID.

@garbear garbear force-pushed the garbear:rename-listitem branch from 5fefd9f to 39989f7 Dec 10, 2016

@garbear

This comment has been minimized.

Copy link
Member Author

commented Dec 11, 2016

jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit 30d903c into xbmc:master Dec 12, 2016

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
default I've found some spare time so building this now
Details
jenkins4kodi Yeah yeah I'll get to it when i have some time
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@garbear garbear deleted the garbear:rename-listitem branch Dec 12, 2016

@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 13, 2016

@Hedda

This comment has been minimized.

Copy link
Contributor

commented Dec 19, 2016

@garbear can maybe be seen as just nitpicking but for consistency in Kodi should this not be called "game client" instead of "gameclient"?

This is as all other clients in Kodi's common grammar for the English languge are written with separation between words for the function noun and "client". IMHO this seperation of the word "client" should also make translation to other languges just a little bit easier.

Examples where the word "client" is already written seperated in Kodi: "PVR client", "VFS client", "UPnP client", "InputStream client".

@MartijnKaijser

This comment has been minimized.

Copy link
Member

commented Dec 19, 2016

You cannot split a label that is used in coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.