Join GitHub today
ListItems: Rename "emulator" property to "gameclient" #11097
From commit description:
This change apparently got dropped in a RetroPlayer rebase. The reason is because gameclient is more generic than emulator, as the game might be a launchable asset instead of a ROM. Also, I would expect "emulator" to be a human-readable string, e.g. "PCSX Re-armed", whereas "gameclient" is more obviously an add-on ID.
I wanted to get this in ASAP before add-ons start using this value.
Dec 12, 2016
@garbear can maybe be seen as just nitpicking but for consistency in Kodi should this not be called "game client" instead of "gameclient"?
This is as all other clients in Kodi's common grammar for the English languge are written with separation between words for the function noun and "client". IMHO this seperation of the word "client" should also make translation to other languges just a little bit easier.
Examples where the word "client" is already written seperated in Kodi: "PVR client", "VFS client", "UPnP client", "InputStream client".