Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pvr] bye, bye libXBMC_pvr.cpp #11109

Merged
merged 3 commits into from
Dec 11, 2016

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Dec 10, 2016

Remove the use of shared add-on library for pvr add-ons.
Reopen from #10408 (due to jenkins problem)

Description

The lib is no more used on add-on. It can be added without changes on add-ons, they need only a recompile.

Motivation and Context

Cleanup binary add-ons

How Has This Been Tested?

Has tested several PVR add-ons with normal operation.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch
Copy link
Member Author

jenkins build this with addons please

@AlwinEsch
Copy link
Member Author

Can someone help me why jenkins always not find the time for the build?

@afedchin
Copy link
Member

jenkins build this with addons please

@AlwinEsch AlwinEsch merged commit 70f08e4 into xbmc:master Dec 11, 2016
@AlwinEsch AlwinEsch deleted the remove-shared-addon-lib-pvr2 branch December 11, 2016 16:56
@MartijnKaijser
Copy link
Member

Why was this merged? Seems like pvr Addons are now broken
http://forum.kodi.tv/showthread.php?pid=2476375#pid2476375

@FernetMenta
Copy link
Contributor

This is dev branch and I see no issue in pvr addons being broken for a short time.

@MartijnKaijser
Copy link
Member

sorry i just saw it was mentioned in the PR description that they need a rebuild. all fine

@MartijnKaijser MartijnKaijser modified the milestone: L 18.0-alpha1 Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants