[PVR][video] Consolidate implementation of "Play", "Mark watched", "Mark unwatched", "Resume from" context menu items #11115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Cleanup
ksooo
changed the title
ksooo
changed the title
|
jenkins build this please |
|
@Jalle19 any comments? I know it's pain to read the large diff, but that's why i split it up into multiple commits. ;-) Stuff is well runtime tested for some time now, btw. Like always I use my family members as beta testers in the living room. No complaints so far. ;-) |
|
Sorry, missed this one. |
ksooo
force-pushed
the
refactor-watched-unwatched-resume
branch
5 times, most recently
from
e77caa2
to
0594f40
Compare
Jalle19
reviewed
Dec 16, 2016
| if (channel) | ||
| return CFileItem(channel); | ||
| } | ||
| return CFileItem(*this); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
…t that CPVRRecording is derived from CVideoInfoTag
…, it physically is in xbmc/video, not xbmc/video/windows
…e from' implementations.
ksooo
force-pushed
the
refactor-watched-unwatched-resume
branch
from
0594f40
to
6e67bec
Compare
|
jenkins build this please |
|
Jenkins macOS error is not related to this PR. make: *** [/Users/Shared/jenkins/workspace/OSX-64/tools/depends/pre-depends/autoconf-pre-depends/../../pre-build-deps/autoconf-2.68.tar.gz] Error 7 autoconf was not found and could not be built. Aborting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both video files and pvr recordings have similar context menu items, like "Play", "Mark watched", "Mark unwatched" and "Resume from". For historical reasons, there are different implementations for these menu items, although lots of code could be shared.
After #10870 got merged it is now possible to consolidate these implementations. This PR does exactly this. :-) A bunch of code refactoring needed as prerequisite for this is also included here.
A nice visual side effect of these changes is that now "Resume" and "Play" for PVR recordings appear at the topmost positions in the context menu. This has been requested by or users for several times.
The code was runtime-tested on Linux an macOS, latest master.
@Jalle19 for review?