[depends] remove rtmp as it's included through ffmpeg or as binary addon #11139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartijnKaijser
added
Type: Cleanup
|
last info from @notspiff was that the addon currently does not bring librtmp. but I might be wrong |
|
Has since been remedied |
|
@MartijnKaijser minors: https://github.com/xbmc/xbmc/blob/master/project/cmake/cpack/deb/packages/kodi.txt.in#L18 |
MartijnKaijser
force-pushed
the
rtmp_cleanup
branch
from
de29433
to
1e8d05e
Compare
|
updated. |
|
looks good. jenkins build this please |
MartijnKaijser
force-pushed
the
rtmp_cleanup
branch
from
1e8d05e
to
5c8e532
Compare
|
@wsnipex jenkins build was fine. Rebased it due to conflict on other merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untested and needs reviewing if something was missed or removed to much